Hi Ted,
Wait a minute... this means it is always on by default. Is this wanted?
This is a new feature and should be tested in the field first?
But you agree this is not right, so I will create a JIRA to track this.
Cheers,
Lars
On Wed, Jan 13, 2016 at 11:13 AM, Ted Yu <yuzhih...@gmail.com> wrote:
> There is RegionNormalizerTracker which tracks region normalizer state up in
> ZK.
>
> When user toggles normalizer switch through shell, the following method
> in MasterRpcServices is called:
>
> public boolean normalizerSwitch(boolean on) {
>
> boolean oldValue =
> master.getRegionNormalizerTracker().isNormalizerOn();
>
> ...
>
> master.getRegionNormalizerTracker().setNormalizerOn(newValue);
>
> In RegionNormalizerTracker :
>
> public boolean isNormalizerOn() {
>
> byte [] upData = super.getData(false);
>
> try {
>
> // if data in ZK is null, use default of on.
>
> return upData == null || parseFrom(upData).getNormalizerOn();
>
> So I guess the config parameter hbase.normalizer.enabled can be dropped.
>
>
> Cheers
>
> On Wed, Jan 13, 2016 at 3:01 AM, Lars George <lars.geo...@gmail.com>
> wrote:
>
> > Hi,
> >
> > Just looking through the new properties and seeing this
> >
> > <property>
> > <name>hbase.normalizer.enabled</name>
> > <value>false</value>
> > <description>If set to true, Master will try to keep region size
> > within each table approximately the same.</description>
> > </property>
> >
> > Searching both branches 1.2 and master reveals it is only used in a test
> to
> > enable it, but never anywhere else to check it is disabled. What am I
> > missing? Is the normalizer always on no matter what you set (with the
> > default "false" not working then)?
> >
> > Lars
> >
>
