During HBASE-15128,  i made some changes to ruby script, it cause a lot of
warning about ruby style.

https://builds.apache.org/job/PreCommit-HBASE-Build/587/artifact/patchprocess/diff-patch-rubocop.txt

A lot of warnings exist already,  i think it is unreasonable.

for example:

1.  /testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:32:3: C: Class
has too many lines. [777/100]
The class length has exceeded 100 already.

2.  /testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:135:81: C:
Line is too long. [99/80]
I think length 100 is more reasonable.


3. /testptch/hbase/hbase-shell/src/main/ruby/hbase/admin.rb:145:30: C:
Prefer single-quoted strings when you don't need string interpolation or
special symbols.
I see many strings in script use double-quoted.

wdyt?

Reply via email to