Duo Zhang created HBASE-17206: --------------------------------- Summary: FSHLog may roll a new writer successfully with unflushed entries Key: HBASE-17206 URL: https://issues.apache.org/jira/browse/HBASE-17206 Project: HBase Issue Type: Bug Components: wal Affects Versions: 2.0.0, 1.4.0 Reporter: Duo Zhang Assignee: Duo Zhang Priority: Critical Fix For: 2.0.0, 1.4.0
Found it when debugging the flakey TestFailedAppendAndSync. The problem is in waitSafePoint. {code} while (true) { if (this.safePointAttainedLatch.await(1, TimeUnit.MILLISECONDS)) { break; } if (syncFuture.isThrowable()) { throw new FailedSyncBeforeLogCloseException(syncFuture.getThrowable()); } } return syncFuture; {code} If we attach the safe point quick enough then we will bypass the syncFuture.isThrowable check and will not throw FailedSyncBeforeLogCloseException. This may cause incosistency between memstore and wal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)