Hi Josh, I will have some time soon to look at this. Definitely of interest.
I may look at it as a process of a port to a branch-1 like code base. Helps that all of the work is on a branch. One thing that would be helpful, maybe in javadoc of an integration test or in the release notes, or on the umbrella JIRA, would be a step by step example of application and verification of a simple space quota, say by namespace. If this already exists a pointer would be helpful. To start I'd want to run through something expected to work. > On Mar 23, 2017, at 10:45 AM, Josh Elser <els...@apache.org> wrote: > > bump > > Josh Elser wrote: >> Rebase is done for those who want to just look at some code. >> >> https://github.com/apache/hbase/compare/HBASE-16961 >> >> Josh Elser wrote: >>> Hiya folks, >>> >>> As advertised (warned? *winks*), all of the sub-tasks on HBASE-16961 >>> have been resolved after being committed to the HBASE-16961 branch in >>> SCM. >>> >>> While Ted has been a stalwart reviewer, it would be good to get another >>> set of eyes (or a few sets) on the changes before considering I start a >>> vote to merge into master. >>> >>> Presently, I'm rebasing the branch on top of master (as it's been a >>> while since I've done that). While I do that, I wanted to ask: what can >>> I do to help make this review process easiest? >>> >>> * Squash commits into one and put on RB? >>> * Pointers to tests that outline how users interact via API? >>> * Put together a little example devs can work through locally? >>> >>> I want to avoid this work lingering in the ether for a long period of >>> time -- I'm happy to try to make what will surely be a difficult review >>> any easier. >>> >>> - Josh
