Ted Yu created HBASE-18808: ------------------------------ Summary: Inaccurate config check in BackupLogCleaner#getDeletableFiles() Key: HBASE-18808 URL: https://issues.apache.org/jira/browse/HBASE-18808 Project: HBase Issue Type: Bug Reporter: Ted Yu
Here is related code: {code} if (this.getConf() == null || !BackupManager.isBackupEnabled(getConf())) { LOG.warn("Backup is not enabled. Check your " + BackupRestoreConstants.BACKUP_ENABLE_KEY + " setting"); return files; } {code} However, in setConf() we don't store the Configuration where backup is disabled: {code} public void setConf(Configuration config) { // If backup is disabled, keep all members null if (!config.getBoolean(BackupRestoreConstants.BACKUP_ENABLE_KEY, BackupRestoreConstants.BACKUP_ENABLE_DEFAULT)) { LOG.warn("Backup is disabled - allowing all wals to be deleted"); return; } {code} This means that once config with backup enabled is remembered, it won't go to disabled state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)