Hi Josh, Yes, you are right, the Yarn Timeline Server uses tags as well as coprocessors. So yes, we do need to update the timeline server usage of tags & coprocessors when those apis change.
@Ted: I like the idea of marking them as LimitedPrivate and noting that YARN TSv2 uses those. thanks Vrushali On Thu, Sep 21, 2017 at 12:15 PM, Ted Yu <yuzhih...@gmail.com> wrote: > Can we mark Tag LimitedPrivate ? > > We know how ATS uses Tags so it should be straight forward to keep their > usage intact. > > On Thu, Sep 21, 2017 at 12:03 PM, Josh Elser <els...@apache.org> wrote: > > > Hiya, > > > > (Background, I'm starting what is likely to be an onerous task of looking > > through downstream components and seeing what is broken with the latest > > hbase-2.0.0*) > > > > Looking at YARN's use of HBase for the Application TimelineServer, I see > > that they're relying on the Tag interface. > > > > Presently, Tag is marked as Private, yet we expose it via the Public > > CellUtil. > > > > My gut reaction is that we should bump Tag up Public since the intent is > > for downstream users to, ya know, use those Tags. Any objections? > > > > If we don't want to expose Tag, we should make a pass over the Public > > methods and mark them as Private (so not as to provide a Public method > with > > Private objects). CellUtil#getTag(Cell, byte) would be one such example. > > > > - Josh > > >
