hi folks, I noticed the code conflict occurs on the imports frequently. To resolve the conflict is a complete waste of time, so i feel it is time to update our imports layout and hold our attraction on it.
The import layout is shown below. (see hbase_eclipse_formatter.xml) javax.* blank line java.* blank line import all other imports blank line import static all other imports Q1: As i see it, two updates should be considered. 1) Should we move the "import static" to the top? (It seems most of files have its static imports on the top) 2) Should we move the shaded class into new blocks? The new layout looks like this. import static all other imports blank line javax.* blank line java.* blank line org.* blank line org.apache.hadoop.hbase.shaded.* blank line import all other imports Q2: Should we check the import layout before committing? Perhaps we can address this in the HBASE-18438. The issue try to add the check of unused imports Any suggestions? Thanks. -- Chia-Ping
