On Mon, Dec 11, 2017 at 12:49 PM, Apekshit Sharma <a...@cloudera.com> wrote:
> Seems like good idea: > - remove long dead dependency > - a bit cleaner code > - hadoop also moved to slf4j > > Quickly looking at codebase to get idea of amount of work required, here > are some numbers: > - LOG.debug : ~1800 > - LOG.trace : ~500 > - LOG.info: ~3000 > > Looking at this patch ( > https://issues.apache.org/jira/secure/attachment/ > 12901002/HBASE-19449.1.patch), > seemed like tedious and repetitive task, was wondering if someone has > automated it already. > Looks like this can help reduce a huge part of grunt work: > https://www.slf4j.org/migrator.html. > > But before progressing, as a basic validation, can we see: > - an example of old vs new log lines (that there is no diff, or we are > comfortable with what's there) > - an example of changes in properties file > > Maybe starting with hbase-examples module for quick POC. > > I like your suggestion Appy, S > -- Appy >