Guanghao Zhang created HBASE-19653:
--------------------------------------

             Summary: Reduce the default hbase.client.start.log.errors.counter
                 Key: HBASE-19653
                 URL: https://issues.apache.org/jira/browse/HBASE-19653
             Project: HBase
          Issue Type: Sub-task
            Reporter: Guanghao Zhang


As we reduce the default retries number to 10 and now the default start log 
errors counter is 9. So it only log the error at the last retry. So we should 
reduce the default hbase.client.start.log.errors.counter, too.

{code}
  /**
   * Configure the number of failures after which the client will start 
logging. A few failures
   * is fine: region moved, then is not opened, then is overloaded. We try to 
have an acceptable
   * heuristic for the number of errors we don't log. 9 was chosen because we 
wait for 1s at
   * this stage.
   */
  public static final String START_LOG_ERRORS_AFTER_COUNT_KEY =
      "hbase.client.start.log.errors.counter";
  public static final int DEFAULT_START_LOG_ERRORS_AFTER_COUNT = 9;
{code}

{code}
public static final int [] RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 
100, 100, 200, 200};
public static final long DEFAULT_HBASE_CLIENT_PAUSE = 100;
{code}

The default pause is 100ms and 100ms * 10 = 1s. The old comment of 
DEFAULT_START_LOG_ERRORS_AFTER_COUNT seems not right...

Open this issue to reduce the default hbase.client.start.log.errors.counter to 
5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to