The issue is specific to us being an ASF project. ASF project repositories can either be set up with "Git WIP" or "Dual Master"[1]. Repositories that use "Git WIP" have their repo mirrored read-only to GitHub. Repositories that use "Dual Master" have the canonical repo on GitHub.
Our main project repo is a "Git WIP" one. That means we don't have write access on GitHub, including merging or closing PRs. Thus the only way we can close PRs on our main repo is to use the github integrated commit message handling[2]. Which relies on pushing to the master branch. Since our main repo is used to create release artifacts we can only have committers pushing to it, which precludes having a bot do so. [1]: "Dual Master" is also sometimes called "gitbox" because of where the asf infra side of it lives. http://git.apache.org/ [2]: https://help.github.com/articles/closing-issues-using-keywords/ On Tue, Sep 4, 2018 at 6:16 PM Misty Linville <[email protected]> wrote: > > The code I posted above is an abstraction that is configured by YAML stuff > like the following (where the test exists for closing PRs): > https://github.com/kubernetes/test-infra/blob/a8cee5a60a2d9476341cf843867221a8bd18a3e8/config/jobs/kubernetes/test-infra/test-infra-periodics.yaml#L47 > > I am not up on Go, but others pointed me there. > > On Tue, Sep 4, 2018 at 4:12 PM, Misty Linville <[email protected]> wrote: > > > Here's the code to the bot: https://github.com/kubernetes/test-infra/tree/ > > master/robots/commenter > > > > On Tue, Sep 4, 2018 at 10:21 AM, Sean Busbey <[email protected]> wrote: > > > >> Do you have a link to an instance of the bot you're talking about? > >> On Tue, Sep 4, 2018 at 11:18 AM Misty Linville <[email protected]> wrote: > >> > > >> > The below snip isn't true. Somehow CNCF has tooling that does it (it is > >> a > >> > bot called fejtabot). I can try to find out more about it if this is a > >> > mechanism we are interested in pursuing. > >> > > >> > On Tue, Sep 4, 2018 at 7:08 AM, Sean Busbey <[email protected]> wrote: > >> > > > >> > > > >> > > We can't automate closing PRs because the only way to close a PR is by > >> > > pushing a commit to our master branch and ASF policy doesn't allow for > >> > > non-commiters pushing into the repository if the repository is used to > >> > > make release artifacts. > >> > > > >> > > > >> > > > >
