I think record the information on jira is enough, so I prefer no empty commit.
Andrew Purtell <apurt...@apache.org> 于2018年9月28日周五 上午9:56写道： > There is an odd commit on master that has 0 file changes. > > commit 98b1feac771d7cc5778fb14089834c99642a3533 > Author: Sean Busbey <bus...@apache.org> > Date: Wed Sep 26 15:00:05 2018 -0700 > > HBASE-21241 Close stale PRs > > * Closes #86 - referenced JIRA has already been merged > * Closes #90 - no response from contributor for 24 days > > Signed-off-by: Peter Somogyi <psomo...@apache.org> > > When did we agree to allow empty commits? I don't recall the discussion. > For one I am opposed to this practice. Isn't the JIRA HBASE-21241 > sufficient to account for this activity? > > -- > Best regards, > Andrew > > Words like orphans lost among the crosstalk, meaning torn from truth's > decrepit hands > - A23, Crosstalk >
