+1 (non-binding)

Used the enhanced hbase-vote.sh with HBASE-22430
<https://issues.apache.org/jira/browse/HBASE-22430> that auto retries
(-Dsurefire.rerunFailingTestsCount=3)
on failures.

* Signature: ok
* Checksum : ok
* Rat check (1.8.0_212): ok
  - mvn clean apache-rat:check
* Built from source (1.8.0_212): ok
  - mvn clean install -DskipTests
* Unit tests pass (1.8.0_212): ok
  - mvn test -P runAllTests
  - retried tests and passed
    - TestBlockEvictionFromClient.testBlockRefCountAfterSplits
    - TestMetaTableMetrics.testConcurrentAccess
    -
TestSnapshotFromMaster.testAsyncSnapshotWillNotBlockSnapshotHFileCleaner

-Stephen

On Thu, May 30, 2019 at 10:41 AM Peter Somogyi <psomo...@apache.org> wrote:

> +1
>
> Signature, checksum: ok
> Apache Rat check: ok
> Build from source: ok
> Unit tests: ok (2 failures but rerun was successful)
> LTT 1m rows: ok
> Web UIs: ok
> Basic shell commands: ok
> Release notes, changes: ok
>
> On Thu, May 30, 2019 at 6:33 PM Artem Ervits <artemerv...@gmail.com>
> wrote:
>
> > +1 non-binding
> > using hbase-vote script on RC1
> >
> >   * Signature: ok
> >   * Checksum : ok
> >   * Rat check (1.8.0_212): ok
> >      - mvn clean apache-rat:check
> >   * Built from source (1.8.0_212): ok
> >
> > The rest of the findings are in RC0 vote.
> >
> >
> >
> >
> >
> > On Thu, May 30, 2019 at 2:10 AM 张铎(Duo Zhang) <palomino...@gmail.com>
> > wrote:
> >
> > > Got it. Let me check the checksums again.
> > >
> > > Stack <st...@duboce.net> 于2019年5月30日周四 下午2:03写道:
> > >
> > > > On Wed, May 29, 2019 at 10:56 PM 张铎(Duo Zhang) <
> palomino...@gmail.com>
> > > > wrote:
> > > >
> > > > > Oh, the RC number is changed... Haven't noticed, let me check the
> new
> > > RC.
> > > > > Why RC0 is dead?
> > > > >
> > > > >
> > > > (Copied over from the RC0 vote)
> > > >
> > > > ...I'm cancelling this vote though because the RC is missing the
> below
> > > > cited commit (See the
> > > > concurrent "[DISCUSS] Moving IA.Public class LossyCounting to
> > IA.Private
> > > in
> > > > all maintenance branches" thread).
> > > >
> > > > Given just a few items have gone in since your vote evaluation,
> please
> > > > hoist your votes up on to the new RC after a check of hash and
> > signature
> > > > given you'd done a bunch of checking of the branch candidate already?
> > > >
> > > > Thank you boys,
> > > > S
> > > >
> > > > commit 6d1b4f7d35d594aa426d8c1cf7e4cec1689c3fb4
> > > > Author: Sakthi <sakthivel.azh...@gmail.com>
> > > > Date:   Thu May 9 14:39:56 2019 -0700
> > > >
> > > >     HBASE-21991 [Addendum] Mark LossCounting as Private
> > > >
> > > >     Signed-off-by: Guanghao Zhang <zg...@apache.org>
> > > >
> > > >
> > > >
> > > >
> > > > > Stack <st...@duboce.net> 于2019年5月30日周四 下午12:39写道:
> > > > >
> > > > > > You voted on RC0 or RC1 Duo?
> > > > > > S
> > > > > >
> > > > > > On Wed, May 29, 2019 at 6:34 PM 张铎(Duo Zhang) <
> > palomino...@gmail.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Oh I've voted on the original thread. I think we have gotten
> > enough
> > > > > > binding
> > > > > > > votes now?
> > > > > > >
> > > > > > > Stack <st...@duboce.net> 于2019年5月30日周四 上午6:16写道:
> > > > > > >
> > > > > > > > The VOTE will remain open for at least 72 hours.
> > > > > > > >
> > > > > > > > [ ] +1 Release this package as Apache HBase 2.1.5
> > > > > > > > [ ] -1 Do not release this package because ...
> > > > > > > >
> > > > > > > > The tag to be voted on is 2.1.5RC1:
> > > > > > > >
> > > > > > > >  https://github.com/apache/hbase/tree/2.1.5RC1
> > > > > > > >
> > > > > > > > The release files, including signatures, digests, as well as
> > > > > CHANGES.md
> > > > > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > > > > >
> > > > > > > >  https://dist.apache.org/repos/dist/dev/hbase/2.1.5RC1/
> > > > > > > >
> > > > > > > > Maven artifacts are available in a staging repository at:
> > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1314/
> > > > > > > >
> > > > > > > > Artifacts were signed with the st...@duboce.net key which
> can
> > be
> > > > > found
> > > > > > > in:
> > > > > > > >
> > > > > > > >  https://dist.apache.org/repos/dist/release/hbase/KEYS
> > > > > > > >
> > > > > > > > To learn more about Apache HBase, please see
> > > > > http://hbase.apache.org/
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Your HBase Release Manager
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to