Thanks for the opportunity to comment. In general the changes are great, it's apparent you went through a few iterations and simplified as much as possible. I left a couple of suggestions and comments on what I think are nits on the review.
On Thu, Dec 12, 2019 at 12:13 PM Andrew Purtell <[email protected]> wrote: > Thanks for the heads's up. 43 changed files... hmm, will try to find some > time. > > On Wed, Dec 11, 2019 at 9:22 AM Josh Elser <[email protected]> wrote: > >> Wellington's been giving me great rounds of review, but if this falls >> into the wheelhouse of something you'd like to look at before it lands >> in master, please give me a shout. >> >> https://issues.apache.org/jira/browse/HBASE-23347 >> https://github.com/apache/hbase/pull/884 >> >> As of right now, I think we're pretty close to a commit. I'm happy to >> hold up if someone wants to review and can make the time to do so. >> >> - Josh >> > > > -- > Best regards, > Andrew > > Words like orphans lost among the crosstalk, meaning torn from truth's > decrepit hands > - A23, Crosstalk > -- Best regards, Andrew Words like orphans lost among the crosstalk, meaning torn from truth's decrepit hands - A23, Crosstalk
