[ 
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey reopened HBASE-24086:
---------------------------------

I am -1 on this change and intend to revert it and the follow-on docs change so 
that we can first have a discussion here or on dev@.

I am concerned that this went in without an in depth reconsideration of the 
issues that come with trying to run against LocalFileSystem discussed in 
HBASE-20354 (where the docs you changed were added) or HBASE-19289 (where the 
check failing on LocalFileSystem first came up) or HBASE-21735 (where this 
first showing up for Hadoop 2 came up when it was backported to HBase 1). 
Furthermore you didn't ping any of the folks involved in any of those 
discussion.

The point of requiring this change is in the config name and emphasizing it is 
_unsafe_. A WARN message in a log is too easy to miss. Folks should not be 
running a production instance against a local filesystem unless they affirm 
they know what they are doing by setting that configuration value.

> Disable output stream capability enforcement when running in standalone mode
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-24086
>                 URL: https://issues.apache.org/jira/browse/HBASE-24086
>             Project: HBase
>          Issue Type: Task
>          Components: master
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> {noformat}
> $ 
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home 
> mvn clean install -DskipTests
> $ 
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home 
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR 
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to 
> become active master                                                          
>                      
> java.io.IOException: cannot get log writer                                    
>                                                                               
>                                                 
>         at 
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>                                                                               
>                       
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>                                                                               
>                          
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>                                                                               
>                       
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>                                                                               
>                       
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>                                                                               
>                           
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>                                                                               
>                           
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>                                                                               
>                                 
>         at 
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>                                                                               
>                            
>         at 
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>                                                                               
>                             
>         at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297) 
>                                                                               
>                                                 
>         at 
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>                                                                               
>       
>         at 
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>                                                                               
>       
>         at 
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>                                                                               
>    
>         at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>                                                                               
>                               
>         at 
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>                                                                               
>                                   
>         at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>                                                                               
>                           
>         at 
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2231)
>                                                                               
>                                  
>         at 
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:621)         
>                                                                               
>                                      
>         at java.lang.Thread.run(Thread.java:748)                              
>                                                                               
>                                                 
> Caused by: 
> org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: 
> hflush                                                                        
>                                         
>         at 
> org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:71)
>                                                                               
>                    
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:169)
>                                                                               
>         
>         at 
> org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166)
>                                                                               
>         
>         at 
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:105)
>                                                                               
>                       
>         ... 18 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to