[ https://issues.apache.org/jira/browse/HBASE-24079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guanghao Zhang reopened HBASE-24079: ------------------------------------ Reopen for cherry-pick to branch-2.2. > [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add > waits on quota table to come online; etc. > --------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-24079 > URL: https://issues.apache.org/jira/browse/HBASE-24079 > Project: HBase > Issue Type: Test > Components: flakies > Reporter: Michael Stack > Assignee: Michael Stack > Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > Some fixes that have accumulated over last few days. > Fixes for weird NPE on construction of ClientAsyncPrefetchScanner, catches > for unexpected, test-killing exceptions in RSProcedureDispatcher and in > CompactSplit; add waits on quota table to come on line and regionservers to > go down before proceeding; add retry if BindException in thrift tests; > disabled a few flakies; etc. Add some debug too. > {code} > > hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java > Refactor to avoid NPE timing issue referencing lock during Construction. > > hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java > Comment > > hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java > Refactor. Catch NPE during startup and return it instead as failed > initialization. > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java > Catch IndexOutOfBounds exception and convert to non-split request. > > hbase-server/src/test/java/org/apache/hadoop/hbase/TestCachedClusterId.java > Make less furious. Make it less flakie. > > hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java > Debug. Catch exception to log, then rethrow. > > hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java > Guess that waiting longer on compaction to succeed may help make this > less flakey. > > hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java > Be explicit about timestamping to avoid concurrent edit landing > server-side and messing up test expectation. > > hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java > Add wait on meta before proceeding w/ test. > > hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java > Be explicit that edits are distinct. > > hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCacheRefCnt.java > Add @Ignore on RAM test... Fails sporadically. > > hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java > Add wait for all RegionServers going down before proceeding; was > messing up RS accounting. > > hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java > Make balancer test sloppier; less restrictive; would fail on occasion > by being just outside test limits. > > hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java > Add wait on quota table coming up; helps make this less flakie. > > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Be explicity about timestamps; see if helps w/ flakie failure. > > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java > Catch and ignore if issue in shutdown; don't care if after test. > > hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java > Comment. > > hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java > Add retry to see if helps w/ odd failure; grant hasn't propagated? > > hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java > Explicit w/ timestamps so no accidental overlap of puts. > > hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java > > hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java > Hack to deal w/ BindException on startup. > > hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThrift2ServerCmdLine.java > Use loopback. > > hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java > Disable flakie test. > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)