[ https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guanghao Zhang resolved HBASE-24973. ------------------------------------ Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to branch-2+. Thanks [~yuqi] for contributing. > Remove read point parameter in method StoreFlush#performFlush and > StoreFlush#createScanner > ------------------------------------------------------------------------------------------ > > Key: HBASE-24973 > URL: https://issues.apache.org/jira/browse/HBASE-24973 > Project: HBase > Issue Type: Improvement > Reporter: yuqi > Assignee: yuqi > Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > Currently, read point parameter in method StoreFlush#performFlush is useless > and can be safely removed. > and then method StoreFlush#createScanner can also remove this parameter > See below > {code:java} > // Some comments here > /** > * Performs memstore flush, writing data from scanner into sink. > * @param scanner Scanner to get data from. > * @param sink Sink to write data to. Could be StoreFile.Writer. > * @param smallestReadPoint Smallest read point used for the flush. > * @param throughputController A controller to avoid flush too fast > */ > protected void performFlush(InternalScanner scanner, CellSink sink, > long smallestReadPoint, ThroughputController throughputController) > throws IOException > {code} > Parameter smallestReadPoint is not used in this method. When > `smallestReadPoint` is removed, inner method `createScanner` can remove this > necessary parameter too -- This message was sent by Atlassian Jira (v8.3.4#803005)