Huaxiang Sun created HBASE-25248:
------------------------------------
Summary: Followup jira to create single thread
ScheduledExecutorService in AsyncConnImpl, and schedule all these periodic tasks
Key: HBASE-25248
URL: https://issues.apache.org/jira/browse/HBASE-25248
Project: HBase
Issue Type: Sub-task
Reporter: Huaxiang Sun
This is a followup Jira for comments in
[https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0.]
{quote}
h4. *[saintstack|https://github.com/saintstack]* [18 hours
ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517040579]
Member
So, implements Stoppable rather than do what the likes of AuthUtil does where
it does createDummyStoppable and then has an internal do-nothing Stoppable?
Makes sense.
Perhaps add comment that it is a do-nothing stop required by ScheduledChore
impls. s/isStopped/stopped/
[!https://avatars1.githubusercontent.com/u/62515050?s=60&v=4|width=28,height=28!|https://github.com/huaxiangsun]
h4. *[huaxiangsun|https://github.com/huaxiangsun]* [18 hours
ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517042290]
Author Member
Will do.
[!https://avatars2.githubusercontent.com/u/45484?s=60&v=4|width=28,height=28!|https://github.com/ndimiduk]
h4. *[ndimiduk|https://github.com/ndimiduk]* [17 hours
ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517057141]
Member
Maybe in the future we can put a default empty implementation on the interface,
and then implementers who don't need it can ignore it.
[!https://avatars3.githubusercontent.com/u/4958168?s=60&u=fc28b222c03c02201d705b025a5293d6c471f7b3&v=4|width=28,height=28!|https://github.com/Apache9]
h4. *[Apache9|https://github.com/Apache9]* [17 hours
ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517057999]
Member
Maybe we could just use a ScheduledExecutorService at client side, the
ChoreService is designed to be used at server side I believe. Anyway, not a
blocker for now.
{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
