Yeah, that is true. It is fixed by HBASE-25238, I did the manual check. Leaving this question to dev discussion. There are multiple rounds of effort for this 2.3.4 release. Unless it is a real issue, hope this vote does not sink just because of this issue.
But again, it is up to dev's agreement and we need to put the decisions into the release guidance. On Fri, Jan 15, 2021 at 4:24 AM Viraj Jasani <[email protected]> wrote: > HBASE-25234 doesn't have corresponding commit > present on branch-2.3 but perhaps it is fine as it > is resolved with comment: "Fixed by HBASE-25238" ? > > Are we find with HBASE-25234 showing up in CHANGELOG? > > On 2021/01/15 03:03:47, Huaxiang Sun <[email protected]> wrote: > > Please vote on this Apache hbase release candidate, > > > > hbase-2.3.4RC4 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache hbase 2.3.4 > > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 2.3.4RC4: > > > > > > https://github.com/apache/hbase/tree/2.3.4RC4 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.3.4RC4/ > > > > > > Maven artifacts are available in a staging repository at: > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1433/ > > > > > > Artifacts were signed with the [email protected] key which can be > > found in: > > > > > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > > > To learn more about Apache hbase, please see > > > > > > http://hbase.apache.org/ > > > > > > Thanks, > > > > Your HBase Release Manager > > >
