Oh, sorry, missed that part. FWIW, if we think this removal is necessary, then we should mark it as 'Incompatible Change', and mention clearly why we remove this public field even in a patch release.
So I'm -1 on releasing RC0 as 2.4.5. Let's either change the issue to 'Incompatible Change' and mention the reason in the release note or add the field back. Thanks. Andrew Purtell <[email protected]> 于2021年7月25日周日 下午11:52写道： > > As I mentioned in my mail this change appears intended and it is only the > removal of a constant field. I think it allowable but you can choose to > factor it into your vote if you like. I think you have? Please clarify with a > -1 if so, please. As you say it’s no problem to amend with a simple change > and move to RC1. > > > > On Jul 25, 2021, at 6:19 AM, 张铎 <[email protected]> wrote: > > > > The compatibility report shows critical problems > > > > https://dist.apache.org/repos/dist/dev/hbase/2.4.5RC0/api_compare_2.4.4_to_2.4.5RC0.html#Type_Binary_Problems_High > > > > It is HBASE-25986 > > https://github.com/apache/hbase/commit/0f313176beed6bf102f0104b9ff21655d500c1d9#diff-a2fcc0281ac9b75ce47204b0db0ca203b1b586c24a51bcd13402ad593e7d6b12 > > > > Where we removed a public field in TableDescritorBuilder, which is > > IA.Public. > > > > Skimming the commit, I do not see the necessity of removing this > > field, so let's push an addendum to add it back? > > > > Thanks. > > > > Guangxu Cheng <[email protected]> 于2021年7月25日周日 下午5:33写道： > >> > >> +1 (binding) > >> * Signature: ok > >> * Checksum : ok > >> * Rat check (1.8.0_201): ok > >> - mvn clean apache-rat:check > >> * Built from source (1.8.0_201): ok > >> - mvn clean install -DskipTests > >> * Unit tests pass (1.8.0_201): ok > >> - mvn package -P runSmallTests > >> * Start in standalone mode: ok > >> * Basic shell commands (CRUD/flush/compact/split): ok > >> * Basic WEB UI: ok > >> ------ > >> Best Regards, > >> Guangxu > >> > >> > >> Andrew Purtell <[email protected]> 于2021年7月24日周六 上午5:27写道： > >> > >>> Please vote on this Apache hbase release candidate, > >>> hbase-2.4.4RC0 > >>> > >>> The VOTE will remain open for at least 72 hours. > >>> > >>> [ ] +1 Release this package as Apache hbase 2.4.4 > >>> [ ] -1 Do not release this package because ... > >>> > >>> The tag to be voted on is 2.4.5RC0: > >>> > >>> https://github.com/apache/hbase/tree/2.4.5RC0 > >>> > >>> This tag currently points to git reference 4a2828386. > >>> > >>> The release files, including signatures, digests, as well as CHANGES.md > >>> and RELEASENOTES.md included in this RC can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/hbase/2.4.5RC0/ > >>> > >>> The API compatibility report can be found at: > >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/hbase/2.4.5RC0/api_compare_2.4.4_to_2.4.5RC0.html > >>> > >>> HBASE-25986 intentionally removed the final boolean field > >>> 'DEFAULT_NORMALIZATION_ENABLED' from HTableDescriptor and > >>> TableDescriptorBuilder. The default setting represented by this field > >>> is preserved by a new entry in hbase-default.xml. I think the change > >>> is acceptable but please be aware of this change when considering your > >>> vote. > >>> > >>> Maven artifacts are available in a staging repository at: > >>> > >>> https://repository.apache.org/content/repositories/orgapachehbase-1459/ > >>> > >>> Artifacts were signed with the 0xD5365CCD key which can be found in: > >>> > >>> https://dist.apache.org/repos/dist/release/hbase/KEYS > >>> > >>> To learn more about Apache hbase, please see > >>> > >>> http://hbase.apache.org/ > >>> > >>> Thanks, > >>> Your HBase Release Manager > >>>
