This is great information. I would feel better about it if we had confirmation that everything is working as expected on branch-2. The reason for this is that master and branch-2 have drifted quite a bit, and the instrumentation points are quite sensitive to internal details of the code. Thus, I don’t assume that behavior demonstrated on master is necessarily applicable to branch-2.
Since no one seems to have demonstrated on the feature branch what I’m hoping for, let me spend some time with the feature branch and/or branch-2 after merge. I think it’s important that we know this works well, as it is a headline feature of 2.5. (If anyone else is really keen to do this demonstration, please let us know!) Related: what’s the status is tracing into HDFS and beyond? Should I expect to see spans all the way down to HDFS disk access? What about kernel system calls? Thanks, Nick On Mon, Aug 30, 2021 at 20:30 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > Before I left Xiaomi, I’ve already set up a testing cluster and collected > the tracing data to Apache Skywalking and show it. > > There are some screen shots, I found them in the private slack channel > between Stack and me. > > > > Tak Lon (Stephen) Wu <tak...@apache.org>于2021年8月31日 周二10:09写道： > >> Hey Nick, IMO you're good, and we should move your concern to another >> discussion topic. >> >> Let me reply here first and see if the created JIRA >> https://issues.apache.org/jira/browse/HBASE-26241 (could be a blocker >> for hbase-2.5.0 release) meets your exception. >> >> If I read your message correctly, even if we have the instruction on >> how to enable opentelemetery for writing trace in HBase's log [1] >> (should have tested in HBASE-25658 [2]) as well as we have the >> interface for other telemetry sinks [3], you would like to see the >> following before releasing 2.5.0 if we're merging HBASE-25853 into >> branch-2? >> >> a. Someone (either the RM or me) can spend a bit on testing end-2-end >> with a graph as result in the JIRA (or hbase book html) that this >> tracing can be rendered at the sink of an external telemetry system >> e.g. Jaeger [4] or zipkin [5]. >> b. For a `service call`, e.g. via a put/get call, how does the trace >> message look like in logs or via from the UI? >> >> [1] https://hbase.apache.org/book.html#tracing >> [2] https://issues.apache.org/jira/browse/HBASE-25658 has the basic >> benchmark >> [3] >> https://danw1ld.medium.com/observability-for-front-end-web-clients-with-opentelemetry-and-jaeger-in-5-minutes-343f719fbf5a >> [4] Jaeger, https://github.com/jaegertracing/jaeger >> [5] zipkin, https://github.com/openzipkin/zipkin >> >> Thanks, >> Stephen >> >> >> On Mon, Aug 30, 2021 at 5:41 PM Nick Dimiduk <ndimi...@apache.org> wrote: >> > >> > +0 >> > >> > Recent PR test failures are unfortunate, but look unrelated. It's >> > unfortunate, because there's enough change here that I think we'd all >> be a >> > lot more comfortable with better confidence that the changeset has not >> > introduced instabilities. >> > >> > I think we're pretty close to cutting a 2.5.0 from this branch. I've not >> > seen anyone report their success at integrating these changes into a >> > telemetry system and showing end-to-end tracing of a service call. As I >> > recall from the last 2.5 discuss thread, we wanted this to be the banner >> > feature for the minor release. Since we don't have this end-to-end >> > confirmation, do we have someone who's volunteered to demonstrate that >> > final proof-of-integration in a timely manner? Perhaps that someone is >> keen >> > to be release manager for 2.5. >> > >> > I didn't see a discuss thread talking about what open items might be >> left >> > before merge, so I raise my question here. Pardon me if these comments >> > should have landed elsewhere. >> > >> > Thanks, >> > Nick >> > >> > On Sun, Aug 29, 2021 at 8:22 PM Tak Lon (Stephen) Wu <tak...@apache.org >> > >> > wrote: >> > >> > > Hi everyone, >> > > >> > > I'm writing this request and propose a merge of HBASE-25853 >> > > <https://issues.apache.org/jira/browse/HBASE-25853> "Backport >> HBASE-22120 >> > > Replace HTrace with OpenTelemetry" to branch-2. The goal is to remove >> > > HTrace and uses OpenTelemetry also in branch-2.5.0+. >> > > >> > > Highlights >> > > * These changes only support async clients and calls >> > > * We will have a separate thread for support sync client in branch-2 >> , see >> > > HBASE-26141 <https://issues.apache.org/jira/browse/HBASE-26141> >> > > >> > > PRs >> > > * The merge PR with 18 reviewed commits >> > > https://github.com/apache/hbase/pull/3637 >> > > * see all those reviewed commits at feature branch HBASE-25853 >> > > <https://github.com/apache/hbase/commits/HBASE-25853> >> > > >> > > Please vote: >> > > [+1] Agree >> > > [+/-0] Neutral >> > > [-1] Disagree (please include actionable feedback) >> > > >> > > Thanks, >> > > Stephen >> > > >> >
