Have submitted an MR about this in the ticket https://issues.apache.org/jira/browse/HBASE-26354. The MR passed the QA.
Sean Busbey <[email protected]> 于2021年9月29日周三 下午10:49写道： > yes, generally a PMC member associated with a specific release should > push the released artifacts to pypi. Someone will need to run down the > details of doing that, but there is precedent of other ASF projects > doing so. > > On Tue, Sep 28, 2021 at 10:14 PM Yutong Xiao <[email protected]> wrote: > > > > Contributing to hbase-connectors is ok for me. But there is a question > > about how to release the package. Currently, I upload the package to pypi > > with my own pypi account. Not clear whether this should change if I > > contribute the client to hbase-connectors. > > > > Reid Chan <[email protected]> 于2021年8月3日周二 下午10:27写道： > > > > > Brief summaries from this thread: > > > > > > I think you can push to hbase-connectors > > > <https://github.com/apache/hbase-connectors> repo. Just create a new > dir > > > hbase-thrift-python, and put your codes under it. > > > Your codes need to be reviewed by good Pythoners in the community. > > > > > > Some follow-up tasks include (but not limited to): > > > > > > - requirements.txt > > > - docs about how to release > > > - some client examples > > > - add some test codes (I'm not sure this part, whether there are > similar > > > conventions in python world) > > > - other related information > > > > > > > > > About the *.thrfit files you mentioned, I can't come up a good idea by > now. > > > Looks like we still need to create two separate PRs to update both > hbase > > > and hbase-connectors repo. > > > However, as *.thrfit files seldom get updated, I feel it should be a > ok. > > > > > > > > > ------ > > > Best Regards, > > > R.C > > > > > > > > > On Tue, Aug 3, 2021 at 10:42 AM Yutong Xiao <[email protected]> > wrote: > > > > > > > Hello, any other thoughts about this? > > > > > > > > Yutong Xiao <[email protected]> 于2021年7月21日周三 上午11:30写道： > > > > > > > > > Hi. I have removed the personal info in the licenses. For the point > > > 3.2, > > > > > thbase is dependent on the hbase.thrift file. I have involved the > > > > > hbase.thrift file, that thbase used, in the repo. In this case, > repo > > > > > separation will lead to a sync problem between the hbase.thrfit > files > > > in > > > > > HBase repo and the connector repo. I am concerned this may make it > hard > > > > for > > > > > maintenance. What do you think? > > > > > > > > > > 张铎(Duo Zhang) <[email protected]> 于2021年7月17日周六 上午9:39写道： > > > > > > > > > >> One of the difficulties of moving hbase-thrift and hbase-rest out > is > > > > >> because we make use of hbase-http in these two modules, at least > for > > > > >> setting up the status servlet... > > > > >> > > > > >> Sean Busbey <[email protected]> 于2021年7月16日周五 下午11:01写道： > > > > >> > > > > >> > maybe a good fit for the hbase-connectors repo? I know we've > talked > > > a > > > > >> > few times about moving the thrift server out there. if we did > both > > > > >> > then the compatibility question becomes just the standard > > > > >> > client/server compatibility provided the thrift server only > uses our > > > > >> > public java client API. > > > > >> > > > > > >> > On Thu, Jul 15, 2021 at 10:21 PM Yutong Xiao < > [email protected]> > > > > >> wrote: > > > > >> > > > > > > >> > > btw for point 2, if allowed I can do that. > > > > >> > > And for point 3.2 it is only a personal idea, the final > decision > > > > >> should > > > > >> > be > > > > >> > > made by the community. > > > > >> > > Besides, many of my python user colleagues started using this > > > > library. > > > > >> > > I think many python users have the demand of a good HBase > python > > > > >> client. > > > > >> > > > > > > >> > > Yutong Xiao <[email protected]> 于2021年7月16日周五 上午11:07写道： > > > > >> > > > > > > >> > > > 1. The license is no problem. > > > > >> > > > 2. This should see if any committer or PMC has interests to > do > > > > that. > > > > >> > > > 3. I can be responsible for those documents. About 3.2, as > > > thbase > > > > >> has > > > > >> > been > > > > >> > > > uploaded to Pypi, I think it would be better if it is a new, > > > > >> separate > > > > >> > repo. > > > > >> > > > > > > > >> > > > Wei-Chiu Chuang <[email protected]> 于2021年7月6日周二 > 上午10:22写道： > > > > >> > > > > > > > >> > > >> Hi > > > > >> > > >> thanks for your interest in contributing the python api to > the > > > > >> HBase > > > > >> > > >> project. > > > > >> > > >> > > > > >> > > >> I quickly check and it doesn't look like there's another > active > > > > >> python > > > > >> > > >> HBase thrift client project at this point. > > > > >> > > >> I don't have a demand to use a python thrift hbase client > > > > library. > > > > >> If > > > > >> > > >> there > > > > >> > > >> are people who will benefit from this library, then it's a > good > > > > >> idea > > > > >> > to > > > > >> > > >> make sure the library is well maintained, by having it > become > > > > part > > > > >> of > > > > >> > the > > > > >> > > >> Apache HBase project and that more developers can > contribute to > > > > it. > > > > >> > > >> > > > > >> > > >> As a hobbyist Python developer I can help review/commit the > > > > patch. > > > > >> > > >> > > > > >> > > >> My two cents: > > > > >> > > >> (1) license: the code is ASL 2.0 so it's compatible. The > text > > > > >> > "Copyright > > > > >> > > >> 2021 Yutong Sean" would need to be removed. > > > > >> > > >> (2) Apache Infra does not manage PyPi. So we (the Apache > HBase > > > > >> project > > > > >> > > >> committers/PMC) will have to do that. > > > > >> > > >> I suspect we will have to replicate this PyPi project and > add > > > the > > > > >> > > >> interested HBase PMCs who's willing to do the release work. > > > > >> > > >> (3) compatibility matrix: we need to document what > versions of > > > > >> HBase > > > > >> > > >> server > > > > >> > > >> is supported. > > > > >> > > >> (3) code: > > > > >> > > >> (3.1) You will need a requirements.txt and preferably > specify > > > the > > > > >> > versions > > > > >> > > >> of the dependencies. > > > > >> > > >> (3.2) If the community accepts it, should it be part of the > > > HBase > > > > >> main > > > > >> > > >> repo, or a new, separate repo? > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> On Mon, Jul 5, 2021 at 7:12 PM Yutong Xiao < > > > [email protected] > > > > > > > > > >> > wrote: > > > > >> > > >> > > > > >> > > >> > Hi, > > > > >> > > >> > > > > > >> > > >> > I used to have a demand to deploy hbase thrift2 service > for > > > > >> python > > > > >> > > >> users. > > > > >> > > >> > So that I developed a python clients API supporting > python > > > 2.7 > > > > >> and > > > > >> > 3.x > > > > >> > > >> for > > > > >> > > >> > hbase thrift2, named thbase < > > > https://pypi.org/project/thbase/> > > > > . > > > > >> > > >> Besides > > > > >> > > >> > that, I also added some features to current thrift2 > service > > > > >> > (HBASE-26025 > > > > >> > > >> > < > > > > >> https://issues.apache.org/jira/projects/HBASE/issues/HBASE-26025> > > > > >> > and > > > > >> > > >> > HBASE-26037 > > > > >> > > >> > < > > > > >> https://issues.apache.org/jira/projects/HBASE/issues/HBASE-26037 > >). > > > > >> > I > > > > >> > > >> > deployed them in the prod environment of my company and > are > > > > >> > compatible > > > > >> > > >> with > > > > >> > > >> > thbase and I will keep maintaining this python API and > add > > > new > > > > >> > features. > > > > >> > > >> > I am glad to contribute thbase to the community, but I > am > > > not > > > > >> > sure if > > > > >> > > >> it > > > > >> > > >> > is possible that such a client could be contributed to > the > > > > >> > community. So > > > > >> > > >> > that I would like to get some advice about this. > > > > >> > > >> > > > > > >> > > >> > Thanks, > > > > >> > > >> > Yutong Sean > > > > >> > > >> > > > > > >> > > >> > > > > >> > > > > > > > >> > > > > > >> > > > > > > > > > > > > >
