Sounds good. We can test just with master branch for now.
> On Nov 30, 2021, at 7:24 PM, 张铎 <palomino...@gmail.com> wrote: > > OK, the problem is that for o.a.h.h.http.resource.JerseyResource under > src/test/java, you need to change all the javax.ws.rs imports to > org.apache.hbase.thirdparty.javax.ws.rs, then the tests will work fine. > This is what I have done > > import org.apache.hbase.thirdparty.javax.ws.rs.DefaultValue; > import org.apache.hbase.thirdparty.javax.ws.rs.GET; > import org.apache.hbase.thirdparty.javax.ws.rs.Path; > import org.apache.hbase.thirdparty.javax.ws.rs.PathParam; > import org.apache.hbase.thirdparty.javax.ws.rs.Produces; > import org.apache.hbase.thirdparty.javax.ws.rs.QueryParam; > import org.apache.hbase.thirdparty.javax.ws.rs.core.MediaType; > import org.apache.hbase.thirdparty.javax.ws.rs.core.Response; > > I think we also need to do this for the hbase-rest module, and also ban the > normal javax.ws.rs imports in our code base. > So let's open an issue for upgrading hbase-thirdparty to 4.0.0, for master > and branch-2. > > WDYT Andrew? > > Thanks. > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年12月1日周三 上午8:02写道： > >> Oh, testJersay... >> >> I guess it is related to HBASE-25863, that's why I asked several times on >> the PR about whether we want to get it in for 4.0.0. >> >> Anyway, let me check whether it is easy to fix. If not, let's discuss >> whether to revert HBASE-25863. >> >> But anyway, HBASE-25863 is a big change, if we do not include it in 4.0.0, >> then maybe we can only include it in 5.0.0... >> >> 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年12月1日周三 上午7:56写道： >> >>> Mind pasting more information? Sometimes we need to update the code in >>> HBase itself when working with newer version of hbase-thirdparty. >>> >>> Andrew Purtell <apurt...@apache.org>于2021年12月1日 周三04:12写道： >>> >>>> -1 (binding) >>>> >>>> Checked signatures and sums, ok >>>> Unpacked tarball, looks good >>>> RAT check passed, ok >>>> Built from source, ok >>>> Built head of branch-2 with -Dhbase-thirdparty.version=4.0.0, fail >>>> >>>> Unit tests in hbase-http pass when using branch-2 POM defaults, but fail >>>> with -Dhbase-thirdparty.version=4.0.0 >>>> >>>> >>>> TestHttpServer.testJersey:519->HttpServerFunctionalTest.readOutput:248 » >>>> FileNotFound >>>> >>>> >>>> >>>> >>>> On Tue, Nov 30, 2021 at 11:39 AM 张铎(Duo Zhang) <palomino...@gmail.com> >>>> wrote: >>>> >>>>> Please vote on this Apache hbase thirdparty release candidate, >>>>> hbase-thirdparty-4.0.0RC0 >>>>> >>>>> The VOTE will remain open for at least 72 hours. >>>>> >>>>> [ ] +1 Release this package as Apache hbase thirdparty 4.0.0 >>>>> [ ] -1 Do not release this package because ... >>>>> >>>>> The tag to be voted on is 4.0.0RC0: >>>>> >>>>> https://github.com/apache/hbase-thirdparty/tree/4.0.0RC0 >>>>> >>>>> This tag currently points to git reference >>>>> >>>>> f38128d895370b163d27a3faf21c47119488d6e6 >>>>> >>>>> The release files, including signatures, digests, as well as CHANGES.md >>>>> and RELEASENOTES.md included in this RC can be found at: >>>>> >>>>> >>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.0.0RC0/ >>>>> >>>>> Maven artifacts are available in a staging repository at: >>>>> >>>>> >>>> https://repository.apache.org/content/repositories/orgapachehbase-1470/ >>>>> >>>>> Artifacts were signed with the 9AD2AE49 key which can be found in: >>>>> >>>>> https://downloads.apache.org/hbase/KEYS >>>>> >>>>> To learn more about Apache hbase thirdparty, please see >>>>> >>>>> http://hbase.apache.org/ >>>>> >>>>> Thanks, >>>>> Your HBase Release Manager >>>>> >>>> >>>> >>>> -- >>>> Best regards, >>>> Andrew >>>> >>>> Words like orphans lost among the crosstalk, meaning torn from truth's >>>> decrepit hands >>>> - A23, Crosstalk >>>> >>>
