Filed HBASE-26592. 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年12月17日周五 12:25写道：
> Oh, when backporting to branch-2, I found that there is a serious problem > with this release. > > We do not include the proto files in protobuf-java jar, I think this is a > side effect of HBASE-26496. > > And on the master branch, hbase-shaded-protobuf also pulls in > protobuf-java 3.19.1 dependency so everything is fine. But for branch-2, we > will need to depend on protobuf 2.5.0 then the compilation is broken. > > Anyway, we should include the proto files in hbase-shaded-protobuf, and > also we should not pull in the original protobuf-java dependency. > > Let me fix this and do a 4.0.1 release. > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年12月10日周五 13:41写道： > >> With 4 binding +1s, no -1, the vote passes. >> >> Let me push out the release. >> >> Thanks all for voting! >> >> 张铎(Duo Zhang) <palomino...@gmail.com> 于2021年12月10日周五 13:40写道： >> >>> Here is my +1, I've been testing it by opening a PR against hbase master >>> branch and it works. >>> >>> See https://github.com/apache/hbase/pull/3910 >>> >>> Yu Li <car...@gmail.com> 于2021年12月10日周五 09:37写道： >>> >>>> +1 >>>> >>>> Checked the diff between 3.5.1 and 4.0.0-rc1: OK ( >>>> https://github.com/apache/hbase-thirdparty/compare/rel/3.5.1...4.0.0RC1 >>>> ) >>>> Checked release note and changes: OK >>>> Checked sums and signatures: OK >>>> Maven clean install from source (1.8.0_121): OK >>>> - Minor: I tried to build a tarball from source following README but >>>> failed >>>> with "No assembly descriptors found" error >>>> Checked the jars in the staging repo: OK >>>> >>>> btw, I haven't followed up for a while and could anyone kindly let me >>>> know >>>> where to find this fancy hbase-vote.sh script, so next time I could also >>>> try it out? Thanks :-) >>>> >>>> Best Regards, >>>> Yu >>>> >>>> >>>> On Fri, 10 Dec 2021 at 05:46, Nick Dimiduk <ndimi...@apache.org> wrote: >>>> >>>> > +1 >>>> > >>>> > I've used the hbase-vote.sh script to evaluate this artifact and >>>> there's a >>>> > problem in the final `run_tests` , executed after `build_from_source`. >>>> > >>>> > * Signature: ok >>>> > * Checksum : ok >>>> > * Rat check (11.0.11): ok >>>> > - mvn clean apache-rat:check >>>> > * Built from source (11.0.11): ok >>>> > - mvn clean install -DskipTests >>>> > * Unit tests pass (11.0.11): failed >>>> > - mvn package -P runAllTests >>>> -Dsurefire.rerunFailingTestsCount=3 >>>> > >>>> > [WARNING] The requested profile "runAllTests" could not be activated >>>> > because it does not exist. >>>> > [ERROR] Failed to execute goal >>>> > org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on >>>> > project hbase-shaded-jackson-jaxrs-json-provider: Error creating >>>> shaded >>>> > jar: duplicate entry: >>>> > META-INF/services/org.apache.hbase.thirdparty.javax.ws.rs >>>> > .ext.MessageBodyWriter >>>> > >>>> > Manually running `mvn clean package` within the source tarball, we >>>> succeed. >>>> > >>>> > I have also triggered a PR build of HBASE-25864 / PR#3243 that uses >>>> this >>>> > RC. The tests are still running. >>>> > >>>> > >>>> https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase-PreCommit-GitHub-PR/detail/PR-3243/5/pipeline/ >>>> > >>>> > On Tue, Dec 7, 2021 at 6:02 PM 张铎(Duo Zhang) <palomino...@gmail.com> >>>> > wrote: >>>> > >>>> > > Ah, Thanks Nick for explaining and thanks Andrew for testing. >>>> > > >>>> > > We still need one more +1 to close this vote. >>>> > > >>>> > > Andrew Purtell <andrew.purt...@gmail.com> 于2021年12月7日周二 05:50写道： >>>> > > >>>> > > > Ok, change my vote to +1 (binding). The hbase-thirdparty build and >>>> > > > artifacts are good. >>>> > > > >>>> > > > > On Dec 6, 2021, at 1:18 PM, Nick Dimiduk <ndimi...@apache.org> >>>> > wrote: >>>> > > > > >>>> > > > > On Mon, Dec 6, 2021 at 11:49 AM Andrew Purtell < >>>> apurt...@apache.org >>>> > > >>>> > > > wrote: >>>> > > > > >>>> > > > >> -1 (binding) >>>> > > > >> >>>> > > > >> Checked sums and signature, ok >>>> > > > >> RAT check passed, ok >>>> > > > >> Built from source, ok >>>> > > > >> Built HEAD of master (d9315fa043) with >>>> > > -Dhbase-thirdparty.version=4.0.0, >>>> > > > >> hbase-http module tests fail >>>> > > > >> >>>> > > > > >>>> > > > > Adoption of this dependency will require changes to master. I >>>> had >>>> > > posted >>>> > > > > necessary changes on https://github.com/apache/hbase/pull/3243 >>>> and >>>> > Duo >>>> > > > did >>>> > > > > his own on https://github.com/apache/hbase/pull/3910. >>>> > > > > >>>> > > > > [ERROR] Tests run: 17, Failures: 0, Errors: 1, Skipped: 2, Time >>>> > > elapsed: >>>> > > > >> 2.29 s <<< FAILURE! - in >>>> org.apache.hadoop.hbase.http.TestHttpServer >>>> > > > >> [ERROR] >>>> org.apache.hadoop.hbase.http.TestHttpServer.testJersey Time >>>> > > > >> elapsed: 0.123 s <<< ERROR! >>>> > > > >> java.io.FileNotFoundException: >>>> > > http://localhost:55106/jersey/foo?op=bar >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1898) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> sun.net.www.protocol.http.HttpURLConnection.access$200(HttpURLConnection.java:92) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1492) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> sun.net.www.protocol.http.HttpURLConnection$9.run(HttpURLConnection.java:1490) >>>> > > > >> at java.security.AccessController.doPrivileged(Native Method) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> java.security.AccessController.doPrivilegedWithCombiner(AccessController.java:784) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1489) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> org.apache.hadoop.hbase.http.HttpServerFunctionalTest.readOutput(HttpServerFunctionalTest.java:248) >>>> > > > >> at >>>> > > > >> >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> org.apache.hadoop.hbase.http.TestHttpServer.testJersey(TestHttpServer.java:519) >>>> > > > >> >>>> > > > >> >>>> > > > >>> On Fri, Dec 3, 2021 at 6:23 AM 张铎(Duo Zhang) < >>>> > palomino...@gmail.com> >>>> > > > >>> wrote: >>>> > > > >>> >>>> > > > >>> Please vote on this Apache hbase thirdparty release candidate, >>>> > > > >>> hbase-thirdparty-4.0.0RC1 >>>> > > > >>> >>>> > > > >>> The VOTE will remain open for at least 72 hours. >>>> > > > >>> >>>> > > > >>> [ ] +1 Release this package as Apache hbase thirdparty 4.0.0 >>>> > > > >>> [ ] -1 Do not release this package because ... >>>> > > > >>> >>>> > > > >>> The tag to be voted on is 4.0.0RC1: >>>> > > > >>> >>>> > > > >>> https://github.com/apache/hbase-thirdparty/tree/4.0.0RC1 >>>> > > > >>> >>>> > > > >>> This tag currently points to git reference >>>> > > > >>> >>>> > > > >>> c81cf5c3d10e85f2f5168b09b51ce14468deddbd >>>> > > > >>> >>>> > > > >>> The release files, including signatures, digests, as well as >>>> > > CHANGES.md >>>> > > > >>> and RELEASENOTES.md included in this RC can be found at: >>>> > > > >>> >>>> > > > >>> >>>> > > > >> >>>> > > >>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-4.0.0RC1/ >>>> > > > >>> >>>> > > > >>> Maven artifacts are available in a staging repository at: >>>> > > > >>> >>>> > > > >>> >>>> > > > >> >>>> > > >>>> https://repository.apache.org/content/repositories/orgapachehbase-1471/ >>>> > > > >>> >>>> > > > >>> Artifacts were signed with the 9AD2AE49 key which can be >>>> found in: >>>> > > > >>> >>>> > > > >>> https://downloads.apache.org/hbase/KEYS >>>> > > > >>> >>>> > > > >>> To learn more about Apache hbase thirdparty, please see >>>> > > > >>> >>>> > > > >>> http://hbase.apache.org/ >>>> > > > >>> >>>> > > > >>> Thanks, >>>> > > > >>> Your HBase Release Manager >>>> > > > >>> >>>> > > > >> >>>> > > > >> >>>> > > > >> -- >>>> > > > >> Best regards, >>>> > > > >> Andrew >>>> > > > >> >>>> > > > >> Words like orphans lost among the crosstalk, meaning torn from >>>> > truth's >>>> > > > >> decrepit hands >>>> > > > >> - A23, Crosstalk >>>> > > > >> >>>> > > > >>>> > > >>>> > >>>> >>>
