Hi team,

By default Style/FrozenStringLiteralComment is enabled in rubocop. If we
update a ruby file, rubocop prompts `Missing frozen string literal comment`
(see
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)
<https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt>
.


To address this warn, we need to add `# frozen_string_literal: true` to the
top of the ruby file(see
https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3631),
which will be added to the top of the `Apache License` and will look
strange.


I don't think this `FrozenStringLiteralComment` check is very necessary.
Can we disable it?


I filed a JIRA: https://issues.apache.org/jira/browse/HBASE-27026 to track
the issue and put a PR https://github.com/apache/hbase/pull/4423.

Welcome to discuss whether this approach is reasonable or not.



Thanks,

Tao Li

Reply via email to