Terribly sorry here! I did not notice Duo's reply in the PR and did not get chance to fix the error in time. Will pay more attention and be more careful when merging PR next time.
Thanks again Duo for fixing the error. Huaxiang On Wed, May 25, 2022 at 6:09 AM 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > Since our UTs are not stable enough, sometimes when we can make sure that > the failure UTs are not caused by the PR, we will merge the PR with a big > red cross. > > But recently, I've seen several times our committers just merged a PR with > a big red cross on the spotless check. It is very easy to fix, just run a > 'mvn spotless:apply'. But if you merge it without fixing the issue, it will > confuse all later contributors because it is not something like the flaky > UTs, it will always fail and cause the pre commit check result for all the > later PRs to fail. > > The newest one which breaks the build is > https://github.com/apache/hbase/pull/4442. I've replied on the PR but got > no response yet. This time I will commit an addendum to fix it, but I hope > all our committers can take the responsibility in the future. > > Thanks. Regards >
