[
https://issues.apache.org/jira/browse/HBASE-27321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27321.
-------------------------------
Fix Version/s: 2.6.0
3.0.0-alpha-4
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to master and branch-2.
The change is a bit big so I do not port them to current release lines.
Thanks [~sunxin] for reviewing!
> The ReplicationLogCleaner is not thread safe but can be called from different
> threads at the same time
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-27321
> URL: https://issues.apache.org/jira/browse/HBASE-27321
> Project: HBase
> Issue Type: Bug
> Components: master, Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Critical
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> In preClean method we will update the class fields and then use them in the
> getDeletableFiles method. This implies that we will have only one cleaner run
> at the same time.
> But actually, in MasterRpcServices.runCleanerChore, we will call execute the
> HFileCleaner and LogCleaner directly, not in the cleanerChore thread.
> This could cause data loss for replication, which is a very serious problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
