Change my vote to +1 binding
The test is not very critical, the problem is we will close the WAL
writer in async way, and also write the trailer in async way, so we
have done some tricks to not let WALEntryStream to consider these
unclosed files as closed uncleanly.
For branch-2.6+, we have done big refactorings on the WALEntryStream
and ProtobufLogReader related code, to fix the problem cleanly. The
changes have not been backported to branch-2.5 since it is too big, so
on branch-2.5 the test is still flaky.
But it is not a big problem, there is no logic error, such as data
loss or something, it only affects the metrics.
Thanks.
张铎(Duo Zhang) <palomino...@gmail.com> 于2024年3月9日周六 21:45写道：
>
> +0, as there is a test failure, will change my vote to +1 or -1 after
> I figure out whether it is a critical problem, please give me one more
> day.
>
> Checked sigs and sums: Matched
> LICENSE and NOTICE: In place
> Compatibility report: 100% compatible
> Built from source:
> mvn clean install -DskipTests -Dhadoop.profile=3.0
> Passed
> Run UTs:
> mvn -Dsurefire.firstPartForkCount=1C
> -Dsurefire.secondPartForkCount=1C -Dsurefire.rerunFailingTestsCount=3
> -Dhadoop.profile=3.0 test -PrunAllTests -fn &>test.log </dev/null &
> TestBasicWALEntryStreamAsyncFSWAL.testCleanClosedWALs and
> TestBasicWALEntryStreamFSHLog.testCleanClosedWALs failed. And I
> checked the flaky dashboard for branch-2.5, they both fail abou 80% of
> times. Need to figure out whether this is a critical problem.
> Start a mini cluster:
> Succeeded.
> Check logs and web pages, nothing unusual
> Run these shell commands, looks fine
> list
> create 't','f'
> put 't','r','f:q','value'
> get 't','r'
> disable 't'
> drop 't'
> list
> Run LTT to load 10000 rows:
> ./bin/hbase ltt -write 4:1024 -num_keys 10000
> Passed
> Run these shell commands, looks fine
> count 'cluster_test'
> scan 'cluster_test', {LIMIT=>10}
> scan 'cluster_test', {FILTER =>
> org.apache.hadoop.hbase.filter.KeyOnlyFilter.new(true)}
> flush 'cluster_test'
> major_compact 'cluster_test'
> disable 'cluster_test'
> drop 'cluster_test'
>
> Andrew Purtell <apurt...@apache.org> 于2024年3月9日周六 07:18写道：
> >
> > PMC,
> >
> > We need one more binding +1 in order to complete this VOTE.
> > Currently we have two binding +1s, one from myself and one from Nick, and
> > one nonbinding +1 from Rajeshbabu.
> >
> > On Fri, Mar 1, 2024 at 1:40 PM Andrew Purtell <apurt...@apache.org> wrote:
> >
> > > Please vote on this Apache HBase release candidate, 2.5.8RC0
> > >
> > > The VOTE will remain open for at least 72 hours.
> > >
> > > [ ] +1 Release this package as Apache HBase 2.5.8
> > > [ ] -1 Do not release this package because ...
> > >
> > > The tag to be voted on is 2.5.8RC0:
> > >
> > > https://github.com/apache/hbase/tree/2.5.8RC0
> > >
> > > This tag currently points to git reference
> > >
> > > 37444de6531b1bdabf2e445c83d0268ab1a6f919
> > >
> > > The release files, including signatures, digests, as well as CHANGES.md
> > > and RELEASENOTES.md included in this RC can be found at:
> > >
> > > https://dist.apache.org/repos/dist/dev/hbase/2.5.8RC0/
> > >
> > > The API compatibility report comparing this RC to the previous release
> > > can be found at:
> > >
> > >
> > > https://dist.apache.org/repos/dist/dev/hbase/2.5.8RC0/api_compare_2.5.7_to_2.5.8RC0.html
> > >
> > > There are no binary or source compatibility problems.
> > >
> > > Maven artifacts are available in a staging repository at:
> > >
> > > https://repository.apache.org/content/repositories/orgapachehbase-1534
> > >
> > > Maven artifacts for Hadoop 3 are available in a staging repository at:
> > >
> > > https://repository.apache.org/content/repositories/orgapachehbase-1535
> > >
> > > Artifacts were signed with the 0xD5365CCD key which can be found in:
> > >
> > > https://downloads.apache.org/hbase/KEYS
> > >
> > > To learn more about Apache HBase, please see
> > >
> > > http://hbase.apache.org/
> > >
> > > Thanks,
> > > Your HBase Release Manager
> > >
> >
> >
> > --
> > Best regards,
> > Andrew
> >
> > Unrest, ignorance distilled, nihilistic imbeciles -
> > It's what we’ve earned
> > Welcome, apocalypse, what’s taken you so long?
> > Bring us the fitting end that we’ve been counting on
> > - A23, Welcome, Apocalypse
