+1 binding. Thanks Nick for driving this release forward.
Checked sigs and sums: Matched
Rat check: Passed
LICENSE and NOTICE: In place
Compatibility report: 100% compatible
Built from source(Temurin-17.0.12+7):
mvn clean install -DskipTests -Dhadoop.profile=3.0
Passed
Run UTs(Temurin-17.0.12+7):
mvn -Dsurefire.firstPartForkCount=1C
-Dsurefire.secondPartForkCount=1C -Dsurefire.rerunFailingTestsCount=3
-Dhadoop.profile=3.0 test -PrunAllTests -fn | tee test.log
As described above, there were some failures but seemed to be my
environment problem
Start a mini cluster(Temurin-17.0.12+7):
Succeeded.
Check logs and web pages, nothing unusual
Run these shell commands, looks fine
list
create 't','f'
put 't','r','f:q','value'
get 't','r'
list
disable 't'
drop 't'
list
Run LTT to load 10000 rows:
./bin/hbase ltt -write 4:1024 -num_keys 10000
Passed
Run these shell commands, looks fine
count 'cluster_test'
scan 'cluster_test', {LIMIT=>10}
scan 'cluster_test', {FILTER =>
org.apache.hadoop.hbase.filter.KeyOnlyFilter.new(true)}
flush 'cluster_test'
major_compact 'cluster_test'
disable 'cluster_test'
drop 'cluster_test'
张铎(Duo Zhang) <palomino...@gmail.com> 于2024年10月14日周一 22:31写道：
>
> Ah I think maybe the problem is because of the precision of the clock in
> KVM...
>
> In this test we will delete a row and then put two values for the same
> row, I tried add a sleep(1) right after the delete
>
> https://github.com/apache/hbase/blob/cac58baf12cbf294baa591b2b4a8eda88b06a1e2/hbase-shell/src/test/ruby/hbase/table_test.rb#L254
>
> The test could pass...
>
> 张铎(Duo Zhang) <palomino...@gmail.com> 于2024年10月14日周一 20:58写道：
> >
> > Ah, so maybe still an environment problem...
> >
> > Let me dig and report back.
> >
> > Nick Dimiduk <ndimi...@apache.org> 于2024年10月14日周一 17:30写道：
> > >
> > > Thanks for looking at this.
> > >
> > > I checked the CI history for the branch before the release and it looked
> > > okay. Looking again today, it seems a bit worse, but I don't see any
> > > hbase-shell failures when I look through the recent failed test runs.
> > >
> > > Running locally, all the tests in hbase-shell pass for me. TestTableShell
> > > is among the tests run.
> > >
> > > $ JAVA_HOME=$JAVA17_HOME mvn clean install -Dhadoop.profile=3.0 -T1.0C -am
> > > -pl hbase-shell -Dmaven.repo.local=$HOME/tmp/maven-repo-local
> > > -DskipTests=true && JAVA_HOME=$JAVA17_HOME mvn test -Dhadoop.profile=3.0
> > > -pl hbase-shell -Dmaven.repo.local=$HOME/tmp/maven-repo-local
> > > ...
> > > [INFO] Results:
> > > [INFO]
> > > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> > > [INFO]
> > > [INFO]
> > > ------------------------------------------------------------------------
> > > [INFO] BUILD SUCCESS
> > > [INFO]
> > > ------------------------------------------------------------------------
> > >
> > > On Mon, Oct 14, 2024 at 4:40 AM 张铎(Duo Zhang) <palomino...@gmail.com>
> > > wrote:
> > >
> > > > I'm running UTs for this RC.
> > > >
> > > > The failures in hbase-server seemed OK, some flakies ones but they
> > > > passed when rerun.
> > > > TestAcidGuaranteesWithEagerPolicy failed but it is known to be heavy and
> > > > flaky.
> > > > TestMutualTlsClientSideNonLocalhost seemed to be my environment problem.
> > > >
> > > > But there are bunch of failures in hbase-shell module, and I manually
> > > > tried running TestTableShell
> > > >
> > > > org/jruby/RubyKernel.java:1233:in `catch'
> > > > org/jruby/RubyKernel.java:1238:in `catch'
> > > > org/jruby/RubyKernel.java:1233:in `catch'
> > > > 256: # Put two columns with colons in their qualifiers
> > > > 257: @test_table.put(rowkey, col1,
> > > > org.apache.hadoop.hbase.util.Bytes.toBytes(1))
> > > > 258: @test_table.put(rowkey, col2,
> > > > org.apache.hadoop.hbase.util.Bytes.toBytes(2))
> > > > ^[[48;5;16;38;5;226;1m => 259: assert_equal(2,
> > > > @test_table._get_internal(rowkey).length)^[[0m
> > > > 260:
> > > > 261: # Increment the second column by 10 => 2 + 10 => 12
> > > > 262: @test_table.incr(rowkey, col2, 10)
> > > > src/test/ruby/hbase/table_test.rb:259:in `block in
> > > > test_should_work_with_qualifiers_with_colons'
> > > > Error:
> > > > ^[[48;5;16;38;5;226;1mtest_should_work_with_qualifiers_with_colons(Hbase::TableSimpleMethodsTest)^[[0m:
> > > > NoMethodError: undefined method `length' for nil:NilClass
> > > >
> > > > Seemed to be real problem or at least test issue?
> > > >
> > > > Nick Dimiduk <ndimi...@apache.org> 于2024年10月9日周三 20:41写道：
> > > > >
> > > > > I have generated an API Compatibility report for this release
> > > > > candidate that includes the LimitedPrivate annotated classes. It is
> > > > > available for your consideration at
> > > > >
> > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.1RC1/api_compare_2.6.0_to_2.6.1RC1_Public_LimitedPrivate.html
> > > > >
> > > > > Thanks,
> > > > > Nick
> > > > >
> > > > > On Wed, Oct 9, 2024 at 2:22 PM Nick Dimiduk <ndimi...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Please vote on this Apache hbase release candidate,
> > > > > > hbase-2.6.1RC1
> > > > > >
> > > > > > The VOTE will remain open for at least 72 hours.
> > > > > >
> > > > > > [ ] +1 Release this package as Apache hbase 2.6.1
> > > > > > [ ] -1 Do not release this package because ...
> > > > > >
> > > > > > The tag to be voted on is 2.6.1RC1:
> > > > > >
> > > > > > https://github.com/apache/hbase/tree/2.6.1RC1
> > > > > >
> > > > > > This tag currently points to git reference
> > > > > >
> > > > > > 7ed50b4dd742269a78875fb32112215f831284ff
> > > > > >
> > > > > > The release files, including signatures, digests, as well as
> > > > > > CHANGES.md
> > > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.1RC1/
> > > > > >
> > > > > > Maven artifacts are available in a staging repository at:
> > > > > >
> > > > > >
> > > > https://repository.apache.org/content/repositories/orgapachehbase-1560/
> > > > > >
> > > > > > Maven artifacts for hadoop3 are available in a staging repository
> > > > > > at:
> > > > > >
> > > > > >
> > > > https://repository.apache.org/content/repositories/orgapachehbase-1561/
> > > > > >
> > > > > > Artifacts were signed with the 0xEF4EBF27 key which can be found in:
> > > > > >
> > > > > > https://downloads.apache.org/hbase/KEYS
> > > > > >
> > > > > > To learn more about Apache hbase, please see
> > > > > >
> > > > > > http://hbase.apache.org/
> > > > > >
> > > > > > Thanks,
> > > > > > Your HBase Release Manager
> > > > > >
> > > >
