I've already cherry-picked to branch-2.6.
Thanks.
Nick Dimiduk <ndimi...@apache.org> 于2025年4月25日周五 00:34写道：
>
> Yeah, okay. Let's try it. Nice one, Junegunn.
>
> On Wed, Apr 16, 2025 at 4:44 PM Nihal Jain <nihalj...@apache.org> wrote:
> >
> > +1 on pushing this to branch-2.6
> >
> > Regards,
> > Nihal
> >
> > On 2025/04/12 04:49:25 "张铎(Duo Zhang)" wrote:
> > > I think this is a useful feature and in general, it should not
> > > introduce any compatibility issues, unless you rely on the error
> > > message when specifying an invalid property value to do something.
> > >
> > > For me I'm OK with integrating it to branch-2.6.
> > >
> > > Thanks.
> > >
> > > Junegunn Choi <junegun...@gmail.com> 于2025年4月12日周六 12:45写道：
> > > >
> > > > Hi HBase community,
> > > >
> > > > HBASE-29137 was recently merged into master and branch-2, and I'd like
> > > > to
> > > > gauge interest or concerns about bringing it into branch-2.6 as well.
> > > >
> > > > In short, HBASE-29137 introduces a simple mechanism to annotate
> > > > configuration parameter constants (we have so many of them!) with
> > > > type information and optional validation predicates.
> > > >
> > > > For example, when a constant is defined like this:
> > > >
> > > > public static final String HREGION_MEMSTORE_BLOCK_MULTIPLIER =
> > > > ConfigKey.INT("hbase.hregion.memstore.block.multiplier", v -> v >
> > > > 0);
> > > >
> > > > TableDescriptorChecker will use the information to detect invalid
> > > > values.
> > > > In the above case, it will reject anything that isn't a positive
> > > > integer.
> > > >
> > > > Previously, running this faulty alter command would crash HBase server.
> > > >
> > > > alter 't', { CONFIGURATION => {
> > > > 'hbase.hregion.memstore.block.multiplier'
> > > > => 'x' } }
> > > >
> > > > Now, it's caught early by validation, making CREATE and ALTER operations
> > > > much safer.
> > > >
> > > > You can read more about it here:
> > > > https://github.com/apache/hbase/pull/6709/files
> > > >
> > > > Since this change improves robustness without affecting user-facing
> > > > behavior, I believe it would be a safe and valuable addition to
> > > > branch-2.6.
> > > > Please let me know if you have any objections or concerns.
> > > >
> > > > Thanks,
> > > > Junegunn Choi.
> > >
