[ https://issues.apache.org/jira/browse/HBASE-29249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wellington Chevreuil resolved HBASE-29249. ------------------------------------------ Resolution: Fixed Merged to master, branch-3, branch-2 and branch-2.6. Thanks for the reviews [~zhangduo] and [~taklwu] ! > Allow for BlockCache implementations to define dynamic properties > ----------------------------------------------------------------- > > Key: HBASE-29249 > URL: https://issues.apache.org/jira/browse/HBASE-29249 > Project: HBase > Issue Type: Improvement > Affects Versions: 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0, 2.6.2 > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Major > Labels: pull-request-available > Fix For: 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.6.3 > > > We have some customers use case finding useful to have some of the > BucketCache configurations dynamically set, such as the accept factor or the > queue addition wait time. > HBASE-28517 has already made some other cache related properties dynamically > configurable, and CacheConfig already implements the > ConfigurationObserver and registers itself for config changes notifications. > Since CacheConfig holds a reference for the BlockCache implementation, we > could just allow for BlockCache implementation to define their own dynamic > configuration logic by define a refreshConfig method in the BlockCache > interface that would get called from CacheConfig.onConfigurationChange(). > > -- This message was sent by Atlassian Jira (v8.20.10#820010)