Sanjeet Malhotra created HBASE-29278:
----------------------------------------
Summary: Replace isEmptyColumn in CompactionScanner with
equivalent method from HBase CellUtil
Key: HBASE-29278
URL: https://issues.apache.org/jira/browse/HBASE-29278
Project: HBase
Issue Type: Improvement
Reporter: Sanjeet Malhotra
Currently we have following utility method defined in Phoenix:
{code:java}
public static boolean isEmptyColumn(Cell cell, byte[] emptyCF, byte[] emptyCQ) {
return CellUtil.matchingFamily(cell, emptyCF, 0, emptyCF.length) &&
CellUtil.matchingQualifier(cell, emptyCQ, 0, emptyCQ.length);
} {code}
Firstly this method gives an impression based on its name that it knows about
emptyCF and emptyCQ while it is only comparing column family and column
qualifier against provided `emptyCF` and `emptyCQ`.
Also, there is an equivalent method in HBase CellUtil:
{code:java}
public static boolean matchingColumn(final Cell left, final byte[] fam, final
byte[] qual) {
return matchingFamily(left, fam) && matchingQualifier(left, qual);
} {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
