[
https://issues.apache.org/jira/browse/HBASE-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-29283.
-------------------------------
Fix Version/s: 2.7.0
3.0.0-beta-2
2.6.3
2.5.12
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to all active branches.
Thanks [~chandrasekhar.k]!
> Replication MetricsSource.sizeOfHFileRefsQueue metrics not updated correctly
> after remove_peer
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-29283
> URL: https://issues.apache.org/jira/browse/HBASE-29283
> Project: HBase
> Issue Type: Bug
> Reporter: Chandra Sekhar K
> Assignee: Chandra Sekhar K
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.6.3, 2.5.12
>
>
> in Replication MetricsSource, the value of lastHFileRefsQueueSize not
> incremented correctly, due to this the corresponding decrement in
> decrSizeOfHFileRefsQueue functions resulting in wrong value.
>
> {code:java}
> public void incrSizeOfHFileRefsQueue(long size) {
> singleSourceSource.incrSizeOfHFileRefsQueue(size);
> globalSourceSource.incrSizeOfHFileRefsQueue(size);
> lastHFileRefsQueueSize = size; //issue here as the value not appended with
> previous value
> }
> public void decrSizeOfHFileRefsQueue(int size) {
> singleSourceSource.decrSizeOfHFileRefsQueue(size);
> globalSourceSource.decrSizeOfHFileRefsQueue(size);
> lastHFileRefsQueueSize -= size; // this results in wrong value
> if (lastHFileRefsQueueSize < 0) {
> lastHFileRefsQueueSize = 0;
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
