[ 
https://issues.apache.org/jira/browse/HBASE-29808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-29808.
----------------------------------
    Fix Version/s: 4.0.0-alpha-1
                   3.0.0-beta-2
                   2.6.5
       Resolution: Fixed

Nice one [~dieterdp_ng], thanks!

> Simplify backup history retrieval
> ---------------------------------
>
>                 Key: HBASE-29808
>                 URL: https://issues.apache.org/jira/browse/HBASE-29808
>             Project: HBase
>          Issue Type: Improvement
>          Components: backup&restore
>            Reporter: Dieter De Paepe
>            Assignee: Dieter De Paepe
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.0.0-alpha-1, 3.0.0-beta-2, 2.6.5
>
>
> The API and code that is used to retrieve the backup history (BackupInfo) is 
> messy. Some points of critique:
>  * There's a specific BackupState value ANY just meant as "don't filter any 
> in this retrieval API"
>  * BackupSystemTable#getBackupHistory and BackupSystemTable#getBackupInfos 
> both retrieve BackupInfo, but don't clearly describe their difference.
>  * There's many different versions of BackupSystemTable#getBackupHistory, 
> which are all very similar, without any real optimizations between them:
> ArrayList<BackupInfo> getBackupHistory(boolean onlyCompleted)
> List<BackupInfo> getBackupHistory()
> List<BackupInfo> getHistory(int n)
> List<BackupInfo> getBackupHistory(int n, BackupInfo.Filter... filters)
> List<BackupInfo> getBackupHistory(String backupRoot)
> List<BackupInfo> getBackupHistoryForTable(TableName name)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to