[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553923
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-712:
----------------------------------------------

Looks good to me.

On a related note, there is currently no way to override the default route 
planner on a per request basis, a feature some users may miss. We probably 
should be retrieving the actual route planner from the HTTP context, where it 
could be overridden, or provide HttpClient#execute method that takes a custom 
route planner as a parameter.

Oleg

> improve HttpRoute API
> ---------------------
>
>                 Key: HTTPCLIENT-712
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-712
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Roland Weber
>            Priority: Trivial
>             Fix For: 4.0 Alpha 3
>
>
> Some of the constructors of HttpRoute have three boolean parameters.
> Use enumerations to reduce the potential for confusion.
> The flags for tunnelled and layered are not independent, since layered 
> implies tunnelled.
> These can be combined to a 3-valued enum.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to