[
https://issues.apache.org/jira/browse/HTTPCLIENT-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084890#comment-13084890
]
Greg Bowyer commented on HTTPCLIENT-1116:
-----------------------------------------
Ah check, I thought that might add confusion as the API does not appear to have
many deprecated methods. I will try to get the done by Monday
If I cast getMaxObjectSizeBytes to an int, whhich is the desirable behaviour if
maxObjectSizeBytes > Integer.MAX_VALUE
- throw an exception
- return (maxObjectSizeBytes >= Integer.MAX_VALUE) ? Integer.MAX_VALUE :
(int) maxObjectSizeBytes
- allow the thing to miscast and overflow into negative numbers
I think the exception would be the preferred idea, but then that breaks the API
at runtime :S
> ResponseCachingPolicy uses integers for sizes
> ---------------------------------------------
>
> Key: HTTPCLIENT-1116
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1116
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.1.1, 4.2 Alpha1
> Reporter: Greg Bowyer
> Labels: cache, policy
> Attachments: 0001-Changed-the-ResponseCachingPolicy-to-use-longs.patch
>
>
> ResponseCachingPolicy currently uses integers for interpreting the size of
> Content-Length, as well internally.
> This causes issues in attempting to use the module for caching entities that
> are over 2GB in size, the module does not fail gracefully, but throws a
> NumberFormatException
> I have a patch that fixes this, by promoting the int -> long, which should
> allow for larger entities to be cached, it also updates the public facing API
> where possible, I don't think that the promotion should break compatibility
> massively
> The changes can also be seen here:
> https://github.com/GregBowyer/httpclient/commit/1197d3f94bd2eedcec32646cd6146748ca2e6fa1
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
