Michael Osipov created HTTPCORE-611:
---------------------------------------
Summary: Minor glitches with TimeValue
Key: HTTPCORE-611
URL: https://issues.apache.org/jira/browse/HTTPCORE-611
Project: HttpComponents HttpCore
Issue Type: Improvement
Components: HttpCore
Affects Versions: 5.0-beta9
Reporter: Michael Osipov
The {{TimeValue}} looks like a very good thing. Some nits can be improved:
* {{NEG_ONE_*SECONDS}} uses plural for the scale of one, but should use singular
* {{defaultsToZeroMillis}} is not consistent with
{{defaultsToNegativeOneSecond}}. It should be {{{defaultsToZeroMilliseconds}}
* {{parse()}} uses {{String.format()}} but never passes value to the format.
{{%s}} is missing.
* {{parse()}} should parse with {{Long.parseLong()}} instead of a biased
locale. 1,200 SECONDS for me a one second and 200 milliseconds. Thus, it should
be language agnostic.
* {{toString()}} should also do at most {{%d}} or {{%s}}.
* {{toMillis()}} and other second fractions use inconsistent naming. I'd expect
it to be {{toMilliseconds()}} and so forth.
[~ggregory]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
