[ 
https://issues.apache.org/jira/browse/HTTPCORE-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441750#comment-17441750
 ] 

Oleg Kalnichevski commented on HTTPCORE-696:
--------------------------------------------

> I have only one question, after receiving a GOAWAY frame, could receive other 
> frame like HEADRES?

[~yinwoods] In my opintion the sender of GOAWAY may _not_ send HEADRES or 
PUSH_PROMISE anymore, but it can receive and discard HEADRES for new streams or 
PUSH_PROMISE from the oppositve endpoint after minimal processing. The receiver 
of GOAWAY should _not_ receive HEADRES for new streams or PUSH_PROMISE from the 
opposite endpoint.

Please review the updated patch:

[https://github.com/apache/httpcomponents-core/commit/8593d4b6a227389fd12ae2a11138d3cb811eb9be]

Oleg

> When H2 connection turns to be graceful shutdown, a single HEADERS or 
> PUSH_PROMISE frame with the END_HEADERS flag set should be consumed
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-696
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-696
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>    Affects Versions: 5.1
>            Reporter: yinwoods
>            Assignee: Oleg Kalnichevski
>            Priority: Major
>             Fix For: 5.1.3, 5.2-alpha3
>
>         Attachments: image-2021-11-08-20-06-43-301.png, 
> image-2021-11-08-20-07-02-610.png
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> current implemention in version 5.1, when connection gracefully shutdown and 
> receives a single HEADERS frame with END_HEADERS flag set, it will throws 
> "Stream refused" exception, not sure about this. 
> As RFC7540 section 4.3 defines, looks like single HEADERS frame should be 
> consumed.
>  
> This code in 
> org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:1073
>  
> !image-2021-11-08-20-07-02-610.png!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to