[
https://issues.apache.org/jira/browse/HTTPCORE-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467274#comment-17467274
]
ASF subversion and git services commented on HTTPCORE-707:
----------------------------------------------------------
Commit cf2ad36fccc93fdd989523b213f161307e0cc094 in httpcomponents-core's branch
refs/heads/HTTPCORE-707 from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=cf2ad36 ]
HTTPCORE-707: H2 connections incorrectly enforce the frame size max limit based
on local settings instead of remote ones
> AbstractH2StreamMultiplexer: FrameOutputBuffer: Frame size exceeds maximum
> --------------------------------------------------------------------------
>
> Key: HTTPCORE-707
> URL: https://issues.apache.org/jira/browse/HTTPCORE-707
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 5.2-alpha1
> Reporter: Lubos Husivarga
> Priority: Major
> Fix For: 5.1.4, 5.2-alpha3
>
> Attachments: context_wire_log.txt, http2_flow_frame.txt
>
>
> AbstractH2StreamMultiplexer initializes outputBuffer with frame size from
> local config:
> _this.outputBuffer = new FrameOutputBuffer(this.outputMetrics,
> this.{*}localConfig{*}.getMaxFrameSize());_
>
> Data are streamed using streamData(...) method which checks maxPayloadSize
> against remote config:
> _final int maxPayloadSize = Math.min(capacity,
> {*}remoteConfig{*}.getMaxFrameSize());_
>
> Issue: When remote config has greater max frame size than local config and
> the payload is also greater than local max frame size, the FrameOutputBuffer
> throws "Frame size exceeds maximum" error, since it compares the payload size
> against local frame size as it was initialized with it, not remote frame size.
>
> My suggestion: AbstractH2StreamMultiplexer.{*}applyRemoteSettings{*}(...)
> should update the outputBuffer's max frame size based on remote config.
>
> I will appreciate your help, as it is really annoying issue depending on
> remote site config and payload size, so it may be spotted randomly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
