ok2c commented on PR #350:
URL:
https://github.com/apache/httpcomponents-core/pull/350#issuecomment-1159785241
@hanasakari That is exactly what I wanted. Cool.Almost there.
1. The build currently fails due to trailing blanks somewhere. That needs to
be fixed.
2. I suppose this bit could be optimized
```
} else if (!TextUtils.isAllASCII(s)) {
hostName = IDN.toASCII(tokenizer.parseContent(s, cursor,
URISupport.PORT_SEPARATORS));
}
else {
hostName = tokenizer.parseContent(s, cursor,
URISupport.PORT_SEPARATORS);
}
```
to
```
else {
hostName = tokenizer.parseContent(s, cursor,
URISupport.PORT_SEPARATORS);
if (!TextUtils.isAllASCII(hostName)) {
hostname = IDN.toASCII(hostname)
}
}
```
3. #format method needs to be symmetrically adjusted.
Oleg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
