michael-o commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1693435870
> > @arturobernalg I am fine with all the proposed changes but I personally think that `URIBuilder` should still support user info as it is not meant to be strictly `http`/`https` specific. > > @ok2c Do we want to support non-http/https specific use-cases that might require userInfo? If so, I can filter by scheme. However, I'd like to reiterate: is this truly in line with our library's primary objectives? I agree with @arturobernalg. Though, this is a generic builder, every scheme has its specifics. We don't test for any other schemes, but http/https. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
