kwin commented on code in PR #553:
URL:
https://github.com/apache/httpcomponents-client/pull/553#discussion_r1507218312
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##########
@@ -134,7 +135,27 @@
* exclusive and may not apply when building {@link CloseableHttpClient}
* instances.
* </p>
- *
+ * The following are the default implementations per component
Review Comment:
I know this is a lot of effort. The other alternative would be to establish
a common naming (e.g. always use `Default` prefix, but this won't be backwards
compatible) or at least clarify in the javadoc of the implementation whether it
is the default one or not. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
