rschmitt commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3299533501
I verified that [apache/httpcomponents-core@ac42dec](https://github.com/apache/httpcomponents-core/commit/ac42decdf5def442928de4f17eb8d54d3f12c066) and [apache/httpcomponents-core@5de2967](https://github.com/apache/httpcomponents-core/commit/5de2967e1b76ea2adb631ed3a0d7f8a03596d0e7) fix the lock-up on my machine. Additionally, I tested b16d6d032d7e2b7e2f2b0f94c5d01375cb1ab21b, using `StaleCheckCommand` to implement `setValidateAfterInactivity` for HTTP/1.1 connections in `PoolingAsyncClientConnectionManager`. It significantly improves stale connection reuse for HTTPS but has no effect on HTTP. I'm satisfied with this, since most production usage these days is HTTPS. I think it would be ideal if the HTTP/1.1 duplexer implemented greedy reads, but I accept that there are other reasons why you don't want to do that. ``` https: Validation disabled: Sequential requests (rapid): 2,450 succeeded; 50 failed (98.00% success rate, 1.96% retriable) https: Validation enabled: Sequential requests (rapid): 2,499 succeeded; 1 failed (99.96% success rate, 0.00% retriable) https: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) https: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) https: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 26.67% retriable) https: Validation enabled: Multiple small batches: 14 succeeded; 1 failed (93.33% success rate, 0.00% retriable) http: Validation disabled: Sequential requests (rapid): 2,475 succeeded; 25 failed (99.00% success rate, 0.76% retriable) http: Validation enabled: Sequential requests (rapid): 2,493 succeeded; 7 failed (99.72% success rate, 0.00% retriable) http: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) http: Validation enabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
