arturobernalg commented on PR #738: URL: https://github.com/apache/httpcomponents-client/pull/738#issuecomment-3400907479
> @arturobernalg Why are we actually doing all this? `AsyncBrotli` is completely unintelligible now. Moreover, the current master works absolutely correctly for me. I tested it with various combinations of having and not having optional dependencies on the classpath and everything worked for me as expected. In fact, we presently do unnecessary reflective calls in `CommonsCompressCodecFactory` in my opinion. It is not a problem that it directly imports `org.apache.commons.compress.compressors` classes at compile time. What is important is that it never gets called from `ContentCodecRegistry` at runtime if Commons Compress is not present. > > What am i missing? @ok2c I assumed the goal was zero compile-time references to optional codecs and pushed everything behind reflection to avoid any potential linkage issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
