ok2c commented on code in PR #633:
URL:
https://github.com/apache/httpcomponents-core/pull/633#discussion_r2837434179
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -875,9 +883,21 @@ private void consumeFrame(final RawFrame frame) throws
HttpException, IOExceptio
if (payload == null || payload.remaining() != 4) {
throw new H2ConnectionException(H2Error.FRAME_SIZE_ERROR,
"Invalid WINDOW_UPDATE frame payload");
}
- final int delta = payload.getInt();
- if (delta <= 0) {
- throw new H2ConnectionException(H2Error.PROTOCOL_ERROR,
"Invalid WINDOW_UPDATE delta");
+ final int delta = payload.getInt() & 0x7fffffff;
+ if (delta == 0) {
Review Comment:
@arturobernalg This logic I do not understand and it seems completely
unrelated to the subject of the change-set. Please put it a separate change-set
to be reviewed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
