garydgregory commented on code in PR #820:
URL:
https://github.com/apache/httpcomponents-client/pull/820#discussion_r3069357395
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -95,12 +95,16 @@ public Timeout getSocketTimeout() {
}
/**
- * Gets the timeout until a new connection is fully established.
+ * Gets the timeout until the target endpoint acknowledges accepting the
connection request.
+ * <p>
+ * Note that isn't the same time as the new connection being fully
established. An HTTPS connection cannot be considered fully established until
the TLS
+ * handshake has been successfully completed.
+ * </p>
* <p>
* A timeout value of zero is interpreted as an infinite timeout.
* </p>
*
- * @return the timeout until a new connection is fully established,
defaults to 3 minutes.
+ * @return the ttimeout until the target endpoint acknowledges accepting
the connection request, defaults to 3 minutes.
Review Comment:
Good catch, fixed in c38b00f8e33c80602e6a2438b8d1123113fee0dc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
