----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19240/#review37297 -----------------------------------------------------------
helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68733> If we're only using this internally, it should be package scope. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68728> Make these variables private unless package access is absolutely necessary. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68727> Java volatile sometimes has unpredictable behavior. I would prefer an AtomicReference. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68730> private helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68734> Make the 3 a constant helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68731> Javadocs would be nice, I think you can generally just copy/paste them from the MonitoringClient interface helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java <https://reviews.apache.org/r/19240/#comment68732> This should be something other than public helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68740> Add some high-level javadocs helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68729> Same comment. Make these private if possible. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68737> private helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68739> If all raw clients fail to connect immediately, this should be in a connecting state, right? helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java <https://reviews.apache.org/r/19240/#comment68743> make these private helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java <https://reviews.apache.org/r/19240/#comment68742> This should include some argument for host helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannClientWrapper.java <https://reviews.apache.org/r/19240/#comment68744> Remove these TODOs - Kanak Biscuitwala On March 14, 2014, 3:17 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19240/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 3:17 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > another refactoring based on last iteration: > 1) remove spectating on monitoring cluster, use a simple round-robin approach > to find the first available monitoring server > 2) add a sharding key in MonitoringEvent > 3) refactor AlertProxy, using direct java function call from clj instead of > jetty/http > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java > 743f8b4 > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringEvent.java > 80006fb > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/ClientUtil.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RawRiemannClient.java > e69de29 > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannClientWrapper.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java > 61e3d6c > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAlertProxy.java > 5fe8ebe > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannConfigs.java > 193b763 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/IntegrationTest.java > 9d28dc3 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/MonitoringTestHelper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestClientServerMonitoring.java > 588bc35 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannAgent.java > 39ece64 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannAlertProxy.java > 700682a > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannClientWrapper.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannMonitoringServer.java > f7d0585 > > Diff: https://reviews.apache.org/r/19240/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
