----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19956/#review39349 -----------------------------------------------------------
Ship it! Ship It! - Zhen Zhang On April 2, 2014, 8:41 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19956/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 8:41 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-423 > > > Repository: helix-git > > > Description > ------- > > commit ba2efd59722b459b8f7e1cf91d5c7a7cd58abc72 > Author: Kanak Biscuitwala <[email protected]> > Date: Wed Apr 2 13:35:26 2014 -0700 > > [HELIX-423] Remove election code duplication, fix metrics reset > > :100644 100644 6a6d296... 3175e8d... M > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > :100644 000000 80cfb10... 0000000... D > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerElection.java > :000000 100644 0000000... 74f84e8... A > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java > :100644 100644 d97b22a... 7d252c5... M > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > :100644 100644 fc80d2a... 2e175d5... M > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > 6a6d296 > > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerElection.java > 80cfb10 > > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > d97b22a > > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java > fc80d2a > > Diff: https://reviews.apache.org/r/19956/diff/ > > > Testing > ------- > > Added new test, existing tests pass. > > > Thanks, > > Kanak Biscuitwala > >
