Hey, is all done, or I still have to do something ?
Thanks, Dharmesh On Sun, Apr 6, 2014 at 10:28 AM, Dharmesh Kakadia <[email protected]>wrote: > Done. > > Also, One more dangling link in http://helix.apache.org/integration.html > https://builds.apache.org/view/G-L/view/Helix/ is 404. > > Thanks, > Dharmesh > > > On Sun, Apr 6, 2014 at 9:20 AM, Kanak Biscuitwala <[email protected]>wrote: > >> Actually what I'd like to do is just fix this bug: >> >> Change >> >> // Filter resources if requested >> if (resources != null && !resources.isEmpty()) { >> idealStates.keySet().retainAll(resources); >> extViews.keySet().retainAll(resources); >> } >> >> to >> >> // Filter resources if requested >> if (resources != null) { >> idealStates.keySet().retainAll(resources); >> extViews.keySet().retainAll(resources); >> } >> >> Thanks, >> Kanak >> ---------------------------------------- >> > From: [email protected] >> > Date: Sun, 6 Apr 2014 09:08:20 +0530 >> > Subject: Re: Wrong code-base link on contributing page >> > To: [email protected] >> > CC: [email protected]; [email protected] >> > >> > Thanks. >> > >> > Let me start with HELIX-413. >> > Looking at the code of o.a.h.t.ClusterStateVerifier, I should change, >> > >> > if (resourceStr != null) { >> > >> > String[] resources = resourceStr.split("[\\s,]"); >> > >> > resourceSet = Sets.newHashSet(resources); >> > >> > } >> > >> > to >> > >> > if (resourceStr != null) { >> > >> > String[] resources = resourceStr.split("[\\s,]"); >> > >> > resourceSet = Sets.newHashSet(resources); >> > >> > }else{ >> > >> > return true; >> > >> > } >> > >> > Is that correct? >> > >> > Thanks, >> > Dharmesh >> > >> > >> > >> > On Sat, Apr 5, 2014 at 11:45 PM, Kanak Biscuitwala <[email protected] >> >wrote: >> > >> >> p.s. I would copy and paste that link instead of clicking it, in case >> the >> >> browser doesn't resolve it correctly. >> >> >> >> ---------------------------------------- >> >>> From: [email protected] >> >>> To: [email protected]; [email protected] >> >>> Subject: RE: Wrong code-base link on contributing page >> >>> Date: Sat, 5 Apr 2014 11:13:10 -0700 >> >>> >> >>> >> >>> Hi, >> >>> >> >>> You can find a list of "newbie" issues here: >> >>> >> >> >> https://issues.apache.org/jira/browse/HELIX-413?jql=project%20%3D%20HELIX%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20in%20(newbie%2C%20starter%2C%20easy%2C%20beginners) >> >>> >> >>> Kanak >> >>> ---------------------------------------- >> >>>> Date: Sat, 5 Apr 2014 11:04:24 -0700 >> >>>> Subject: Re: Wrong code-base link on contributing page >> >>>> From: [email protected] >> >>>> To: [email protected] >> >>>> CC: [email protected] >> >>>> >> >>>> I think we have marked some of the issues as easy/beginner/starter. >> >> Kanak, >> >>>> do you know how to find them. >> >>>> >> >>>> thanks >> >>>> kishore G >> >>>> >> >>>> >> >>>> On Sat, Apr 5, 2014 at 10:26 AM, Dharmesh Kakadia < >> [email protected] >> >>>wrote: >> >>>> >> >>>>> Thanks Kishore. I think currently its fine. I will let you know if I >> >> plan >> >>>>> to do more there. >> >>>>> >> >>>>> Also, is there a starts-issues-list where new-comers can start >> >>>>> contributing? I am trying to see if I can (second time actually). >> >>>>> >> >>>>> Thanks, >> >>>>> Dharmesh >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> On Sat, Apr 5, 2014 at 9:37 PM, kishore g <[email protected]> >> wrote: >> >>>>> >> >>>>>> Hi Dharmesh, >> >>>>>> >> >>>>>> Thanks for pointing it out. Since its a small change, I took care >> of >> >> it. >> >>>>>> However if you are interested in making more changes, I can give >> you >> >> the >> >>>>>> permission to edit the wiki. The only thing I would need is your >> >> apache >> >>>>>> wiki id. >> >>>>>> >> >>>>>> thanks, >> >>>>>> Kishore G >> >>>>>> >> >>>>>> >> >>>>>> On Sat, Apr 5, 2014 at 6:45 AM, Dharmesh Kakadia < >> [email protected] >> >>>>>>>wrote: >> >>>>>> >> >>>>>>> Hi, >> >>>>>>> >> >>>>>>> Just noticed that the code-base link on Contributor workflow page >> ( >> >>>>>>> >> >> https://cwiki.apache.org/confluence/display/HELIX/Contributor+Workflow >> >>>>>> ), >> >>>>>>> still points to old, non-existing link. >> >>>>>>> >> >>>>>>> How can I correct it? >> >>>>>>> >> >>>>>>> Thanks, >> >>>>>>> Dhamesh >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>> >> >> >> >> >> >> > >
