----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28578/#review63444 -----------------------------------------------------------
Ship it! Ship It! - Shi Lu On Dec. 1, 2014, 10:11 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28578/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 10:11 p.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-546 > > > Repository: helix-git > > > Description > ------- > > First part of supporting REST api for Helix job queue management: > - Refactor TaskDriver and TaskUtil so we can reuse ZkClient from HelixWebAdmin > - Also remove unused imports to reduce compile warnings. > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/PropertyKey.java a5a3561 > helix-core/src/main/java/org/apache/helix/examples/BootstrapProcess.java > 73f1175 > helix-core/src/main/java/org/apache/helix/examples/ExampleProcess.java > e023cf9 > helix-core/src/main/java/org/apache/helix/examples/Quickstart.java b80d458 > helix-core/src/main/java/org/apache/helix/manager/zk/Cache.java 354a9f6 > > helix-core/src/main/java/org/apache/helix/manager/zk/DefaultSchedulerMessageHandlerFactory.java > 5451a81 > helix-core/src/main/java/org/apache/helix/manager/zk/WriteThroughCache.java > 4ad0f0f > helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java 77c32af > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackCache.java > a02cedf > helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java 7d300a5 > > helix-core/src/main/java/org/apache/helix/messaging/handling/AsyncCallbackService.java > c218a15 > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTask.java > d9f7ae2 > > helix-core/src/main/java/org/apache/helix/messaging/handling/MessageHandler.java > 96784c2 > helix-core/src/main/java/org/apache/helix/model/HealthStat.java 715927f > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterMBeanObserver.java > 5922ea9 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/StateTransitionStatMonitor.java > 20a4a07 > > helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java > 039d076 > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java a9a3ac0 > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java 17388af > helix-core/src/main/java/org/apache/helix/task/Workflow.java 2356c7f > helix-core/src/main/java/org/apache/helix/tools/CLMLogFileAppender.java > 326607f > helix-core/src/main/java/org/apache/helix/util/ZKClientPool.java 0c45020 > helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java c8514ef > > helix-core/src/test/java/org/apache/helix/TestRelayIdealStateCalculator.java > ca58659 > helix-core/src/test/java/org/apache/helix/ZkTestHelper.java b3f6f75 > > helix-core/src/test/java/org/apache/helix/integration/TestCustomIdealState.java > 5467932 > > helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java > e3b0cc7 > > helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java > 3cf4ed5 > helix-core/src/test/java/org/apache/helix/integration/TestDriver.java > 4dad7c0 > > helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java > 734e2b4 > > helix-core/src/test/java/org/apache/helix/integration/TestSessionExpiryInTransition.java > 965b8ef > > helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMSessionExpiry.java > e8adf03 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java > 73945fe > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheSyncOpSingleThread.java > 251234f > > helix-core/src/test/java/org/apache/helix/messaging/TestAsyncCallbackSvc.java > 2be955f > > Diff: https://reviews.apache.org/r/28578/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
