Github user kanakb commented on a diff in the pull request:

    https://github.com/apache/helix/pull/31#discussion_r33892316
  
    --- Diff: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 
---
    @@ -363,6 +373,43 @@ public void addResourceToCluster(String clusterName, 
String resourceName, int nu
             bucketSize, maxPartitionsPerInstance);
       }
     
    +  /**
    +   * Create an IdealState for a resource that belongs to a resource group 
We use
    +   * "resourceGroupName$resourceInstanceTag" as the IdealState znode name 
to differetiate different
    +   * resources from the same resourceGroup.
    +   */
    +  public IdealState createIdealStateForResourceGroup(String 
resourceGroupName,
    +      String resourceTag, int numPartition, int replica, String 
rebalanceMode) {
    +    String idealStateId = IdealState.getIdealStateName(resourceGroupName, 
resourceTag);
    +    IdealState idealState = new IdealState(idealStateId);
    +
    +    idealState.setNumPartitions(numPartition);
    +    idealState.setStateModelDefRef("OnlineOffline");
    --- End diff --
    
    Shouldn't this be an argument?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to